Re: [patch] Add dg-require-effective-target fpic to gcc.target/powerpc tests

[Segher Boessenkool <segher@kernel.crashing.org>]

Hi!

On Tue, Nov 03, 2020 at 10:12:54AM +0100, Olivier Hainque wrote:
> This change is a proposal to add 
> 
>  /* { dg-require-effective-target fpic } */
> 
> to a few tests in gcc.target/powerpc that do use
> -fpic or -fPIC but don't currently query the target
> support.
> 
> This corresponds to what many other fpic tests do
> and helps the vxWorks ports at least, as -fpic is
> typically not supported in at least one of the two
> major modes of such port (kernel vs RTP).

This is fine for trunk, thanks!

> --- a/gcc/testsuite/gcc.target/powerpc/pr84112.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr84112.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile { target powerpc*-*-* } }*/
> +/* { dg-require-effective-target fpic } */
>  /* { dg-options "-mdejagnu-cpu=power8 -O3 -fstack-protector-strong -fpic" } */

You could make that

/* { dg-do compile } */

at the same time, if you want?  If that is easy for you, don't bother
otherwise.


Segher