From: Jonathan Wakely <jwakely@redhat.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
Iain Sandoe <idsandoe@googlemail.com>
Subject: Re: [PATCH] libstdc++: Fix error shown during Solaris build
Date: Mon, 16 Nov 2020 10:32:40 +0000 [thread overview]
Message-ID: <20201116103240.GS503596@redhat.com> (raw)
In-Reply-To: <yddima5y5a3.fsf@CeBiTec.Uni-Bielefeld.DE>
On 16/11/20 11:17 +0100, Rainer Orth wrote:
>Hi Jonathan,
>
>> Currently this is shown when building libstdc++ on Solaris:
>>
>> -lrt: open: No such file or directory
>>
>> The error comes from the make_sunver.pl script which tries to open each
>> of its arguments. The arguments are passed by this make rule:
>>
>> perl ${glibcxx_srcdir}/scripts/make_exports.pl \
>> libstdc++-symbols.ver \
>> $(libstdc___la_OBJECTS:%.lo=.libs/%.o) \
>> `echo $(libstdc___la_LIBADD) | \
>> sed 's,/\([^/.]*\)\.la,/.libs/\1.a,g'` \
>> > $@ || (rm -f $@ ; exit 1)
>>
>> The $(libstdc___la_LIBADD) variable includes $(GLIBCXX_LIBS) which
>> contains -lrt on Solaris.
>>
>> This patch adds another sed script to filter -l arguments from the echo
>> command. In order to reliably match ' -l[^ ]* ' the echo arguments are
>> quoted and a space added before and after them. This might be overkill
>> just to remove -lrt from the start of the string, but should be robust
>> in case other -l arguments are added to $(GLIBCXX_LIBS), or in case the
>> $(libstdc___la_LIBADD) libraries are reordered.
>>
>> libstdc++-v3/ChangeLog:
>>
>> * src/Makefile.am (libstdc++-symbols.ver-sun): Remove -lrt from
>> arguments passed to make_sunver.pl script.
>> * src/Makefile.in: Regenerate.
>>
>> Tested sparc-solaris2.11. Rainer, does this look OK?
>
>it does, but let me give it a try with both GNU sed and Solaris sed: we
>had too many weird issues with the latter ;-(
I think the machine I tested on (gcc211 in the compile farm) only has
Solaris sed in the PATH, and it works there.
I did try to use "-l ?[[:alnum:]]+" but Solaris sed only supports BREs
(as POSIX requires) and there doesn't seem to be an equivalent of the
GNU sed -E option to use EREs.
next prev parent reply other threads:[~2020-11-16 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:07 Jonathan Wakely
2020-11-13 11:16 ` Jonathan Wakely
2020-11-13 11:22 ` Iain Sandoe
2020-11-16 10:23 ` Rainer Orth
2020-11-16 10:28 ` Jonathan Wakely
2020-11-16 10:17 ` Rainer Orth
2020-11-16 10:32 ` Jonathan Wakely [this message]
2020-11-16 10:37 ` Jonathan Wakely
2020-11-16 11:47 ` Rainer Orth
2020-11-16 11:46 ` Rainer Orth
2020-11-16 11:54 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116103240.GS503596@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=idsandoe@googlemail.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).