From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id 829853944821
 for <gcc-patches@gcc.gnu.org>; Mon, 16 Nov 2020 11:55:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 829853944821
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-337-P5s7CZRGNtGGkpz8UMV_zA-1; Mon, 16 Nov 2020 06:55:00 -0500
X-MC-Unique: P5s7CZRGNtGGkpz8UMV_zA-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 921CD1084D62;
 Mon, 16 Nov 2020 11:54:58 +0000 (UTC)
Received: from localhost (unknown [10.33.36.170])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 076A650B44;
 Mon, 16 Nov 2020 11:54:57 +0000 (UTC)
Date: Mon, 16 Nov 2020 11:54:57 +0000
From: Jonathan Wakely <jwakely@redhat.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
 Iain Sandoe <idsandoe@googlemail.com>
Subject: Re: [PATCH] libstdc++: Fix error shown during Solaris build
Message-ID: <20201116115457.GU503596@redhat.com>
References: <20201113110735.GA505111@redhat.com>
 <yddima5y5a3.fsf@CeBiTec.Uni-Bielefeld.DE>
 <20201116103240.GS503596@redhat.com>
 <ydd4klpy15x.fsf@CeBiTec.Uni-Bielefeld.DE>
MIME-Version: 1.0
In-Reply-To: <ydd4klpy15x.fsf@CeBiTec.Uni-Bielefeld.DE>
X-Clacks-Overhead: GNU Terry Pratchett
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2020 11:55:03 -0000

On 16/11/20 12:46 +0100, Rainer Orth wrote:
>Hi Jonathan,
>
>>>> libstdc++-v3/ChangeLog:
>>>>
>>>> 	* src/Makefile.am (libstdc++-symbols.ver-sun): Remove -lrt from
>>>> 	arguments passed to make_sunver.pl script.
>>>> 	* src/Makefile.in: Regenerate.
>>>>
>>>> Tested sparc-solaris2.11. Rainer, does this look OK?
>>>
>>>it does, but let me give it a try with both GNU sed and Solaris sed: we
>>>had too many weird issues with the latter ;-(
>>
>> I think the machine I tested on (gcc211 in the compile farm) only has
>> Solaris sed in the PATH, and it works there.
>
>I've now tested the patch on Solaris 11.3 with all of /bin/sed,
>/usr/xpg4/bin/sed, and /usr/gnu/bin/sed.  Worked perfectly fine, so the
>patch is ok, thanks for taking care of this.

Pushed now, thanks for checking.