From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id C9338385E83A for ; Mon, 16 Nov 2020 12:10:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9338385E83A Received: by mail-pf1-x42e.google.com with SMTP id c20so13905311pfr.8 for ; Mon, 16 Nov 2020 04:10:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m1VFHn5W6vF7vZynaRkoEaZM33NSY+9NxniZyPzXdVc=; b=cEora30n7VE2S52rjDWRIX+7ZRqMVSgv1LlpCwNdgbvAaa9SMPdDEEm6nTSV/b0O7d Y4fDAlpP4wVsqbm8K3G/pvLVUBiIE7hibVxOKckmCVZvJJsj8BLHF9EAmGQVmkmQfQDu IG40IxksEu78SD1EWvO5seGft/KVfDNQDHZ6efZwq5ox3arlsM6bOimWUZ0gUMs7SvEC eddxnq2RdN45NsZ73lMbnp+ormzz8akiLjFpJzHEBU6x5gnPFxeQZtPJjHTmfW+k52G6 rt04hoD0rhBC5Ar+oY/UXOeNvZZSVgONqVTOPdAwaYA6xQmEAJGlksXDvrJWcHbLkazf fCjw== X-Gm-Message-State: AOAM532QuOIyBFDd2/WXDYVYaF6B2ZrBAmguUfbtEWe1EYh4jglSbAsk 1F0h+vCYq9iiSOhZH9kQGy/gF/Vg2cg= X-Google-Smtp-Source: ABdhPJzDPfIGZu61vsfA8g25o+ln1JcKMxfBmaO+GtHkgVwVQrsbB/Lds/uAXzsI9KWogHXx58AKww== X-Received: by 2002:a17:90a:890a:: with SMTP id u10mr16291704pjn.88.1605528608591; Mon, 16 Nov 2020 04:10:08 -0800 (PST) Received: from gnu-cfl-2.localdomain (c-69-181-90-243.hsd1.ca.comcast.net. [69.181.90.243]) by smtp.gmail.com with ESMTPSA id l190sm17443825pfl.205.2020.11.16.04.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:10:07 -0800 (PST) Received: from gnu-cfl-2.localdomain (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id DD33F1A0177; Mon, 16 Nov 2020 04:10:06 -0800 (PST) From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Subject: [PATCH] pointer-compare-1.c: Add __attribute__((used)) Date: Mon, 16 Nov 2020 04:10:04 -0800 Message-Id: <20201116121004.938169-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3040.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2020 12:10:11 -0000 I am going to install this patch as requested: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97803#c5 H.J. --- c-c++-common/asan/pointer-compare-1.c assumes the certain order for variable placement. Add __attribute__((used)) to avoid variable placement changes due to SHF_GNU_RETAIN. PR testsuite/97803 * c-c++-common/asan/pointer-compare-1.c (global1): Add __attribute__((used)) (global2): Likewise. (small_global): Likewise. (large_global): Likewise. --- gcc/testsuite/c-c++-common/asan/pointer-compare-1.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/c-c++-common/asan/pointer-compare-1.c b/gcc/testsuite/c-c++-common/asan/pointer-compare-1.c index 1ce349e4917..4b558bf8179 100644 --- a/gcc/testsuite/c-c++-common/asan/pointer-compare-1.c +++ b/gcc/testsuite/c-c++-common/asan/pointer-compare-1.c @@ -14,12 +14,13 @@ foo (char *p, char *q) v = p > q; } -char global1[100] = {}, global2[100] = {}; +char __attribute__((used)) global1[100] = {}; +char __attribute__((used)) global2[100] = {}; char __attribute__((used)) smallest_global[5] = {}; -char small_global[7] = {}; +char __attribute__((used)) small_global[7] = {}; char __attribute__((used)) little_global[10] = {}; char __attribute__((used)) medium_global[4000] = {}; -char large_global[5000] = {}; +char __attribute__((used)) large_global[5000] = {}; char __attribute__((used)) largest_global[6000] = {}; int -- 2.28.0