From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 427CB386F018 for ; Wed, 18 Nov 2020 09:36:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 427CB386F018 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-WsKfs7oBPEW3wHz4IxEiFw-1; Wed, 18 Nov 2020 04:36:41 -0500 X-MC-Unique: WsKfs7oBPEW3wHz4IxEiFw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29EFD18B9F85; Wed, 18 Nov 2020 09:36:40 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-127.ams2.redhat.com [10.36.113.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B58A86B8E5; Wed, 18 Nov 2020 09:36:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 0AI9aaKn020441 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 18 Nov 2020 10:36:37 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 0AI9aZ2q020440; Wed, 18 Nov 2020 10:36:35 +0100 Date: Wed, 18 Nov 2020 10:36:35 +0100 From: Jakub Jelinek To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] options, lto: Optimize streaming of optimization nodes Message-ID: <20201118093635.GI3788@tucnak> Reply-To: Jakub Jelinek MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2020 09:36:44 -0000 Hi! Reposting with self-contained description per Joseph's request: Honza mentioned that especially for the new param machinery, most of streamed values are probably going to be the default values. Perhaps somehow we could stream them more effectively. This patch implements it and brings further savings, the size goes down from 574 bytes to 273 bytes, i.e. less than half. Not trying to handle enums because the code doesn't know if (enum ...) 10 is even valid, similarly non-parameters because those really generally don't have large initializers, and params without Init (those are 0 initialized and thus don't need to be handled). Bootstrapped/regtested again on x86_64-linux and i686-linux, ok for trunk? 2020-11-18 Jakub Jelinek * optc-save-gen.awk: Initialize var_opt_init. In cl_optimization_stream_out for params with default values larger than 10, xor the default value with the actual parameter value. In cl_optimization_stream_in repeat the above xor. --- gcc/optc-save-gen.awk.jj 2020-09-14 10:51:54.493740942 +0200 +++ gcc/optc-save-gen.awk 2020-09-14 11:39:39.441602594 +0200 @@ -1186,6 +1186,7 @@ for (i = 0; i < n_opts; i++) { var_opt_val_type[n_opt_val] = otype; var_opt_val[n_opt_val] = "x_" name; var_opt_hash[n_opt_val] = flag_set_p("Optimization", flags[i]); + var_opt_init[n_opt_val] = opt_args("Init", flags[i]); n_opt_val++; } } @@ -1257,10 +1258,21 @@ for (i = 0; i < n_opt_val; i++) { otype = var_opt_val_type[i]; if (otype ~ "^const char \\**$") print " bp_pack_string (ob, bp, ptr->" name", true);"; - else if (otype ~ "^unsigned") - print " bp_pack_var_len_unsigned (bp, ptr->" name");"; - else - print " bp_pack_var_len_int (bp, ptr->" name");"; + else { + if (otype ~ "^unsigned") { + sgn = "unsigned"; + } else { + sgn = "int"; + } + if (name ~ "^x_param" && !(otype ~ "^enum ") && var_opt_init[i]) { + print " if (" var_opt_init[i] " > (" var_opt_val_type[i] ") 10)"; + print " bp_pack_var_len_" sgn " (bp, ptr->" name" ^ " var_opt_init[i] ");"; + print " else"; + print " bp_pack_var_len_" sgn " (bp, ptr->" name");"; + } else { + print " bp_pack_var_len_" sgn " (bp, ptr->" name");"; + } + } } print " for (size_t i = 0; i < sizeof (ptr->explicit_mask) / sizeof (ptr->explicit_mask[0]); i++)"; print " bp_pack_value (bp, ptr->explicit_mask[i], 64);"; @@ -1281,10 +1293,18 @@ for (i = 0; i < n_opt_val; i++) { print " if (ptr->" name")"; print " ptr->" name" = xstrdup (ptr->" name");"; } - else if (otype ~ "^unsigned") - print " ptr->" name" = (" var_opt_val_type[i] ") bp_unpack_var_len_unsigned (bp);"; - else - print " ptr->" name" = (" var_opt_val_type[i] ") bp_unpack_var_len_int (bp);"; + else { + if (otype ~ "^unsigned") { + sgn = "unsigned"; + } else { + sgn = "int"; + } + print " ptr->" name" = (" var_opt_val_type[i] ") bp_unpack_var_len_" sgn " (bp);"; + if (name ~ "^x_param" && !(otype ~ "^enum ") && var_opt_init[i]) { + print " if (" var_opt_init[i] " > (" var_opt_val_type[i] ") 10)"; + print " ptr->" name" ^= " var_opt_init[i] ";"; + } + } } print " for (size_t i = 0; i < sizeof (ptr->explicit_mask) / sizeof (ptr->explicit_mask[0]); i++)"; print " ptr->explicit_mask[i] = bp_unpack_value (bp, 64);"; Jakub