public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Thomas Rodgers <rodgert@appliantology.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>,
	gcc-patches List <gcc-patches@gcc.gnu.org>,
	tom@tromey.com
Subject: Re: [PATCH] libstdc++: Enable <thread> without gthreads
Date: Fri, 20 Nov 2020 11:52:12 +0000	[thread overview]
Message-ID: <20201120115212.GL1312820@redhat.com> (raw)
In-Reply-To: <20201119190804.GF1312820@redhat.com>

On 19/11/20 19:08 +0000, Jonathan Wakely wrote:
>On 19/11/20 13:36 +0000, Jonathan Wakely wrote:
>>On 16/11/20 14:43 -0800, Thomas Rodgers wrote:
>>>This patch looks good to me.
>>
>>Committed now.
>
>This patch was also needed, but I don't understand why I didn't see
>the FAILs on gcc135 in teh cfarm.

PCH. My test config on gcc135 uses PCH, and so all headers were
included. The host I tested on later uses --disable-libstdcxx-pch and
so saw the failure.

Mystery solved.


  reply	other threads:[~2020-11-20 11:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11 16:13 Jonathan Wakely
2020-11-11 17:31 ` Jonathan Wakely
2020-11-12 17:07   ` Jonathan Wakely
2020-11-16 22:43     ` Thomas Rodgers
2020-11-19 13:36       ` Jonathan Wakely
2020-11-19 19:08         ` Jonathan Wakely
2020-11-20 11:52           ` Jonathan Wakely [this message]
2020-11-19 18:25     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120115212.GL1312820@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=rodgert@appliantology.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).