From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D8BFF385701F for ; Fri, 20 Nov 2020 11:52:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D8BFF385701F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-7dlKz8OWN2e0qDNYZj-mYA-1; Fri, 20 Nov 2020 06:52:14 -0500 X-MC-Unique: 7dlKz8OWN2e0qDNYZj-mYA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7AE8210051BB; Fri, 20 Nov 2020 11:52:13 +0000 (UTC) Received: from localhost (unknown [10.33.36.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id E735460853; Fri, 20 Nov 2020 11:52:12 +0000 (UTC) Date: Fri, 20 Nov 2020 11:52:12 +0000 From: Jonathan Wakely To: Thomas Rodgers Cc: libstdc++ , gcc-patches List , tom@tromey.com Subject: Re: [PATCH] libstdc++: Enable without gthreads Message-ID: <20201120115212.GL1312820@redhat.com> References: <20201111161340.GA115319@redhat.com> <20201111173107.GX503596@redhat.com> <20201112170745.GC503596@redhat.com> <20201119133647.GE1312820@redhat.com> <20201119190804.GF1312820@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201119190804.GF1312820@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2020 11:52:18 -0000 On 19/11/20 19:08 +0000, Jonathan Wakely wrote: >On 19/11/20 13:36 +0000, Jonathan Wakely wrote: >>On 16/11/20 14:43 -0800, Thomas Rodgers wrote: >>>This patch looks good to me. >> >>Committed now. > >This patch was also needed, but I don't understand why I didn't see >the FAILs on gcc135 in teh cfarm. PCH. My test config on gcc135 uses PCH, and so all headers were included. The host I tested on later uses --disable-libstdcxx-pch and so saw the failure. Mystery solved.