From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 0A567385702C for ; Sat, 21 Nov 2020 05:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0A567385702C Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AL51s6s181483; Sat, 21 Nov 2020 00:27:35 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34xtvehue3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Nov 2020 00:27:35 -0500 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0AL5330f185008; Sat, 21 Nov 2020 00:27:34 -0500 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 34xtvehudt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Nov 2020 00:27:34 -0500 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AL5Qtei013955; Sat, 21 Nov 2020 05:27:33 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma02dal.us.ibm.com with ESMTP id 34xth90sfh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Nov 2020 05:27:33 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AL5RW9T11141806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Nov 2020 05:27:32 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF665AC059; Sat, 21 Nov 2020 05:27:32 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 66059AC05E; Sat, 21 Nov 2020 05:27:32 +0000 (GMT) Received: from ibm-toto.the-meissners.org (unknown [9.65.203.26]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Sat, 21 Nov 2020 05:27:32 +0000 (GMT) Date: Sat, 21 Nov 2020 00:27:30 -0500 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , Jakub Jelinek , gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt , Peter Bergner Subject: Re: [PATCH] PowerPC Fix ibm128 defaults for pr70117.c test. Message-ID: <20201121052730.GA17995@ibm-toto.the-meissners.org> Mail-Followup-To: Michael Meissner , Segher Boessenkool , Jakub Jelinek , gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt , Peter Bergner References: <20201115171747.GA10343@ibm-toto.the-meissners.org> <20201118214320.GQ2672@gate.crashing.org> <20201118215349.GT3788@tucnak> <20201118222909.GR2672@gate.crashing.org> <20201119080805.GA27187@ibm-toto.the-meissners.org> <20201119140302.GS2672@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119140302.GS2672@gate.crashing.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-21_02:2020-11-20, 2020-11-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011210031 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Nov 2020 05:27:38 -0000 On Thu, Nov 19, 2020 at 08:03:02AM -0600, Segher Boessenkool wrote: > On Thu, Nov 19, 2020 at 03:08:05AM -0500, Michael Meissner wrote: > > On Wed, Nov 18, 2020 at 04:29:09PM -0600, Segher Boessenkool wrote: > > > Mike, please add a comment, what number it represents? Okay for trunk > > > with that, thanks. > > > > > > (Should those not be define in some header though?) > > > > When long double is IBM extended double, then LDBL_MAX, etc. is set with math.h > > (and the __ version created by the compiler). We don't have min/max for the > > funky MD only floating point numbers defined. I got the number by printing > > LDBL_MAX in fact and just pasting that in. > > Sure -- I am suggesting to always define __IBM128_MAX__ and the like, > which then can be used to define LDBL_MAX, but also can be used > directly. I have posted patches for this as a new set of patches. Rather than trying to create IBM 128-bit long double min/max/etc. defines, I just marked the test as needing IBM 128-bit long double. I did look into providing defines for these. Unfortunately the function that creates these (builtin_define_float_constants) is static. And the caller of that function (c_cpp_builtins) does not have a target hook or other method to provide for these defines for MD specific floating point types. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.ibm.com, phone: +1 (978) 899-4797