From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 48D4B3858D37 for ; Sun, 22 Nov 2020 06:31:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 48D4B3858D37 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AM6235s026590; Sun, 22 Nov 2020 01:31:07 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34ybq3eq2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 22 Nov 2020 01:31:06 -0500 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0AM62ELA027086; Sun, 22 Nov 2020 01:31:06 -0500 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 34ybq3eq2m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 22 Nov 2020 01:31:06 -0500 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AM6QxRb005333; Sun, 22 Nov 2020 06:31:05 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma02dal.us.ibm.com with ESMTP id 34xth98n3g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 22 Nov 2020 06:31:05 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AM6V4FF6029964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 22 Nov 2020 06:31:04 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B744AB2067; Sun, 22 Nov 2020 06:31:04 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 480D3B2065; Sun, 22 Nov 2020 06:31:04 +0000 (GMT) Received: from ibm-toto.the-meissners.org (unknown [9.65.199.253]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTPS; Sun, 22 Nov 2020 06:31:04 +0000 (GMT) Date: Sun, 22 Nov 2020 01:31:02 -0500 From: Michael Meissner To: David Edelsohn Cc: Michael Meissner , GCC Patches , Segher Boessenkool , Bill Schmidt , Peter Bergner Subject: Re: [PATCH 2/3] PowerPC: require IBM long double for pr70117. Message-ID: <20201122063102.GA13929@ibm-toto.the-meissners.org> Mail-Followup-To: Michael Meissner , David Edelsohn , GCC Patches , Segher Boessenkool , Bill Schmidt , Peter Bergner References: <20201121052230.GA15702@ibm-toto.the-meissners.org> <20201121053710.GD17995@ibm-toto.the-meissners.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-21_04:2020-11-20, 2020-11-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 impostorscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011220039 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Nov 2020 06:31:12 -0000 On Sat, Nov 21, 2020 at 10:46:45AM -0500, David Edelsohn wrote: > On Sat, Nov 21, 2020 at 12:37 AM Michael Meissner > wrote: > > > > PowerPC: require IBM long double for pr70117. > > > > Since the test is explicitly checking for IBM extended double, do not try to > > run it when long double is IEEE 128-bit. > > > > I have tested this patch and the first patch in the series on a little endian > > power9 system with 3 compilers that have the 3 different long double types > > configured. I verified that this test is listed as unsupported if long double > > is not IBM 128-bit, and it passes if long double is IBM 128-bit. > > > > Can I check this patch into the master branch? After an appropriate soak-in > > time, can I back port this patch to the previous open GCC trees? > > > > gcc/testsuite/ > > 2020-11-21 Michael Meissner > > > > PR target/70117 > > * gcc.target/powerpc/pr70117.c: Only run the test if long double > > uses the IBM extended double format. > > --- > > gcc/testsuite/gcc.target/powerpc/pr70117.c | 22 ++++------------------ > > 1 file changed, 4 insertions(+), 18 deletions(-) > > > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr70117.c b/gcc/testsuite/gcc.target/powerpc/pr70117.c > > index 3bbd2c595e0..2077d15afd4 100644 > > --- a/gcc/testsuite/gcc.target/powerpc/pr70117.c > > +++ b/gcc/testsuite/gcc.target/powerpc/pr70117.c > > @@ -1,26 +1,12 @@ > > -/* { dg-do run { target { powerpc*-*-linux* powerpc*-*-darwin* powerpc*-*-aix* rs6000-*-* } } } */ > > -/* { dg-options "-std=c99 -mlong-double-128 -O2" } */ > > +/* { dg-require-effective-target ppc_long_double_ibm } */ > > +/* { dg-options "-std=c99 -O2" } */ > > Mike, > > You still need a > > /* { dg-do run } */ > > line. But without any target specified. > > Segher may have other comments. > > Thanks, David Thanks. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.ibm.com, phone: +1 (978) 899-4797