From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH] PowerPC: PR libgcc/97543, fix 64-bit long double issues
Date: Mon, 23 Nov 2020 16:36:29 -0600 [thread overview]
Message-ID: <20201123223629.GP2672@gate.crashing.org> (raw)
In-Reply-To: <20201119234302.GA30873@ibm-toto.the-meissners.org>
Hi!
On Thu, Nov 19, 2020 at 06:43:02PM -0500, Michael Meissner wrote:
> One feature of the current GNU attribute implementation is if you have a shared
> library (such as libgcc_s.so), the GNU attributes for the shared library is an
> inclusive OR of all of the modules within the library. This means if any
> module uses the -mlong-double-128 option and uses long double, the GNU
> attributes for the library will indicate that it uses 128-bit IBM long
> doubles. If you have a static library, you will get the warning only if you
> actually reference a module with the attribute set.
(You use "module" a lot, here and in the patch; just "object file" would
be clearer I think. "Module" has a specific (and different)( meaning in
many contexts.)
> 2) I turned off GNU attributes for building the shared library or for
> building the IBM 128-bit long double support.
It's not clear to me what error disabling setting it for the static
library avoids? Not that it *hurts* of course. Do you have an example
for this?
Anyway, okay for trunk (and backports later). Thanks!
Segher
prev parent reply other threads:[~2020-11-23 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 23:43 Michael Meissner
2020-11-23 22:36 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123223629.GP2672@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).