From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 48796385481C for ; Mon, 23 Nov 2020 23:58:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 48796385481C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 0ANNv4Bq003664; Mon, 23 Nov 2020 17:57:04 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 0ANNv48d003663; Mon, 23 Nov 2020 17:57:04 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 23 Nov 2020 17:57:04 -0600 From: Segher Boessenkool To: Michael Meissner , gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt , Peter Bergner Subject: Re: [PATCH] PowerPC: PR 97791: Fix gnu attributes. Message-ID: <20201123235704.GQ2672@gate.crashing.org> References: <20201119235429.GA32109@ibm-toto.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119235429.GA32109@ibm-toto.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2020 23:58:07 -0000 Hi! On Thu, Nov 19, 2020 at 06:54:29PM -0500, Michael Meissner wrote: > 1) Only set gnu attribute #4 if long double was passed. Passing __float128 > when long double is IBM or __ibm128 when long double is IEEE no longer sets the > attribute. This resulted in a lot of false positives, such as using __float128 > and no long double support. Sure, makes sense (and is a bug fix actually). > 2) Do not set the gnu attribute if a mode used by long double (TF or DF) is > used in a move. The moves do not differentiate between the long double type > and similar types. Delete the three tests that tested this. This, too. > diff --git a/gcc/testsuite/gcc.target/powerpc/gnuattr1.c b/gcc/testsuite/gcc.target/powerpc/gnuattr1.c > deleted file mode 100644 > index cf46777849a..00000000000 > --- a/gcc/testsuite/gcc.target/powerpc/gnuattr1.c > +++ /dev/null > @@ -1,15 +0,0 @@ > -/* { dg-do compile { target { powerpc*-linux-* } } } */ > -/* { dg-require-effective-target powerpc_vsx_ok } */ > -/* { dg-options "-O2 -mvsx -mlong-double-64" } */ > -/* { dg-final { scan-assembler "gnu_attribute 4, 9" } } */ > - > -/* Check that if we can do the long double operation without doing an emulator > - call, such as with 64-bit long double support, that we still set the > - appropriate .gnu_attribute. */ > - > -long double a; > - > -void add1 (void) > -{ > - a++; > -} But this *does* use long double. So this testcase is valid, and you should not delete it. Instead, it points out you have a deficiency in the code, one that used to be hidden by how you used moves to set the attribute. Same for the other testcases you delete. Segher