From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 5DC6E385802F for ; Fri, 27 Nov 2020 16:24:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5DC6E385802F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-32Hzn2dtMFOm9V9NinYEvw-1; Fri, 27 Nov 2020 11:23:57 -0500 X-MC-Unique: 32Hzn2dtMFOm9V9NinYEvw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EEA27800D62; Fri, 27 Nov 2020 16:23:55 +0000 (UTC) Received: from localhost (unknown [10.33.37.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D8725C1C2; Fri, 27 Nov 2020 16:23:55 +0000 (UTC) Date: Fri, 27 Nov 2020 16:23:54 +0000 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes Message-ID: <20201127162354.GA2308844@redhat.com> MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="huq684BweRXVnRxX" Content-Disposition: inline X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 16:24:01 -0000 --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This allows using "testsuite/*" in libstdc++-v3/ChangeLog entries, which was one of the original motivations for adding wildcard support in the first place: https://gcc.gnu.org/pipermail/gcc/2020-June/232719.html contrib/ChangeLog: * gcc-changelog/git_commit.py (wildcard_prefixes): Add libstdc++ testsuite directory. OK to push? This still doesn't actually meet my needs, because I'd like to be able to do: * testsuite/foo/*: Something for foo tests. * testsuite/bar/baz/*: Something for baz tests. So it would be nice if wildcards worked for any directory below a wildcard prefix (as long as the directory actually exists). It also seems that I can't have a commit where all changes are described by a wildcard entry. It seems to require a non-wildcard one too. But that means I can't make changes to hundreds of tests without also making some other change, or doing something like: * testsuite/foo/foo-1.cc: A specific change. * testsuite/*: Likewise. I suppose I can live with the latter, but it would still be nice if this worked: * testsuite/foo/foo-1.cc: A specific change. * testsuite/foo/*: Likewise. * testsuite/bar/baz/*: Likewise. i.e. sub-directories below a wildcard prefix. --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" commit 5cdb6541a49f1ac716a3f1be281c9487d9b198c5 Author: Jonathan Wakely Date: Fri Nov 27 16:00:58 2020 gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes This allows using "testsuite/*" in libstdc++-v3/ChangeLog entries, which was one of the original motivations for adding wildcard support in the first place: https://gcc.gnu.org/pipermail/gcc/2020-June/232719.html contrib/ChangeLog: * gcc-changelog/git_commit.py (wildcard_prefixes): Add libstdc++ testsuite directory. diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py index d0ac23c22aa4..3ebc6fd305e0 100755 --- a/contrib/gcc-changelog/git_commit.py +++ b/contrib/gcc-changelog/git_commit.py @@ -138,7 +138,8 @@ ignored_prefixes = { wildcard_prefixes = { 'gcc/testsuite/', - 'libstdc++-v3/doc/html/' + 'libstdc++-v3/doc/html/', + 'libstdc++-v3/testsuite/' } misc_files = { --huq684BweRXVnRxX--