From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3AE52386EC33 for ; Fri, 4 Dec 2020 13:43:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3AE52386EC33 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-545-TuqoNQp2N5-e3jkF2yn7sg-1; Fri, 04 Dec 2020 08:43:43 -0500 X-MC-Unique: TuqoNQp2N5-e3jkF2yn7sg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0150C801F97; Fri, 4 Dec 2020 13:43:42 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-127.ams2.redhat.com [10.36.113.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88C8D620D7; Fri, 4 Dec 2020 13:43:41 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 0B4DhcTx3574239 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 4 Dec 2020 14:43:38 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 0B4DhbEO3574237; Fri, 4 Dec 2020 14:43:37 +0100 Date: Fri, 4 Dec 2020 14:43:37 +0100 From: Jakub Jelinek To: Matthias Klose Cc: Kito Cheng , Jim Wilson , GCC Patches Subject: Re: [PATCH] RISC-V: Canonicalize --with-arch Message-ID: <20201204134337.GL3788@tucnak> Reply-To: Jakub Jelinek References: <20201201081313.68385-1-kito.cheng@sifive.com> <5cabdbd3-2317-59d0-b12d-f6611efd1103@ubuntu.com> MIME-Version: 1.0 In-Reply-To: <5cabdbd3-2317-59d0-b12d-f6611efd1103@ubuntu.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2020 13:43:48 -0000 On Fri, Dec 04, 2020 at 02:38:54PM +0100, Matthias Klose wrote: > On 12/4/20 9:07 AM, Kito Cheng via Gcc-patches wrote: > > Committed, thanks :) > > > > On Thu, Dec 3, 2020 at 8:51 AM Jim Wilson wrote: > >> > >> On Tue, Dec 1, 2020 at 12:13 AM Kito Cheng wrote: > >>> > >>> - We would like to canonicalize the arch string for --with-arch for > >>> easier handling multilib, so split canonicalization part to a stand > >>> along script to shared the logic. > >>> > >>> gcc/ChangeLog: > >>> > >>> * config/riscv/multilib-generator (arch_canonicalize): Move > >>> code to arch-canonicalize, and call that script to canonicalize arch > >>> string. > >>> (canonical_order): Move code to arch-canonicalize. > >>> (LONG_EXT_PREFIXES): Ditto. > >>> (IMPLIED_EXT): Ditto. > >>> * config/riscv/arch-canonicalize: New. > >>> * config.gcc (riscv*-*-*): Canonicalize --with-arch. > >> > >> > >> Looks OK to me. > > that breaks the bootstrap if python is not available. The python command might > not be available, so please check for python3, python, or python2. > > And it adds an unconditional build dependency on python for building the riscv > targets. Yeah, doing it in awk or shell might be better. We do use python for various things, but generally try not to require it for build and make check, e.g. some contrib/ scripts used during build and make check have shell variants etc. Jakub