From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 84A673870881 for ; Thu, 10 Dec 2020 16:14:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 84A673870881 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-_YHvAxg0M5e1AtW9jFhDmw-1; Thu, 10 Dec 2020 11:14:19 -0500 X-MC-Unique: _YHvAxg0M5e1AtW9jFhDmw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E247C107ACE6; Thu, 10 Dec 2020 16:14:17 +0000 (UTC) Received: from localhost (unknown [10.33.36.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94F6F10016F6; Thu, 10 Dec 2020 16:14:16 +0000 (UTC) Date: Thu, 10 Dec 2020 16:14:15 +0000 From: Jonathan Wakely To: Tulio Magno Quites Machado Filho Cc: Michael Meissner , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Bill Schmidt , David Edelsohn , Segher Boessenkool , Peter Bergner Subject: Re: [PATCH] libstdc++: Add C++ runtime support for new 128-bit long double format Message-ID: <20201210161415.GA2309743@redhat.com> References: <20201111215001.GA231697@redhat.com> <20201130213029.GA10782@ibm-toto.the-meissners.org> <20201201151011.GA2761400@redhat.com> <20201201160430.GL2309743@redhat.com> <87v9dibiah.fsf@linux.ibm.com> <20201204003542.GC2309743@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201204003542.GC2309743@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2020 16:14:27 -0000 On 04/12/20 00:35 +0000, Jonathan Wakely wrote: >On 03/12/20 20:07 -0300, Tulio Magno Quites Machado Filho via Libstdc++ wrote: >>Jonathan Wakely via Libstdc++ writes: >> >>>diff --git a/libstdc++-v3/configure.ac b/libstdc++-v3/configure.ac >>>index cbfdf4c6bad..d25842fef35 100644 >>>--- a/libstdc++-v3/configure.ac >>>+++ b/libstdc++-v3/configure.ac >>>@@ -421,12 +425,43 @@ case "$target" in >>> port_specific_symbol_files="\$(top_srcdir)/config/os/gnu-linux/ldbl-extra.ver" >>> case "$target" in >>> powerpc*-*-linux*) >>>- LONG_DOUBLE_COMPAT_FLAGS="$LONG_DOUBLE_COMPAT_FLAGS -mno-gnu-attribute" ;; >>>+ LONG_DOUBLE_COMPAT_FLAGS="$LONG_DOUBLE_COMPAT_FLAGS -mno-gnu-attribute" >>>+ # Check for IEEE128 support in libm: >>>+ AC_CHECK_LIB(m, frexpf128, >> >>I suggest to replace frexpf128 with __frexpieee128. >> >>The former is available on a glibc that support _Float128 (since glibc 2.26). >>The later is available on a glibc that supports binary128 long double (since >>glibc 2.32) > >Hmm, yes, you pointed me to __frexpieee128 a few months ago, but for >some reason I either didn't switch to using it, or lost a patch when >squashing and rebasing branches. Hopefully I just forgot to change it, >but I'll double check to make sure I haven't left any work on an old >branch. Thanks for suggesting it (again!) As expected, it still works with a check for __frexpieee128 instead. So are you happy for me to push this to master with that change? (It won't be until Tuesday now, as I have some time off).