From: Jonathan Wakely <jwakely@redhat.com>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>,
Michael Meissner <meissner@linux.ibm.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
libstdc++@gcc.gnu.org, Bill Schmidt <wschmidt@linux.ibm.com>,
gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH] libstdc++: Add C++ runtime support for new 128-bit long double format
Date: Thu, 10 Dec 2020 17:27:19 +0000 [thread overview]
Message-ID: <20201210172719.GB2309743@redhat.com> (raw)
In-Reply-To: <5f94d7e3-772c-398f-e2f6-7eb62d4509d3@linux.ibm.com>
On 10/12/20 11:14 -0600, Peter Bergner via Libstdc++ wrote:
>On 12/10/20 10:14 AM, Jonathan Wakely wrote:
>> On 04/12/20 00:35 +0000, Jonathan Wakely wrote:
>>> On 03/12/20 20:07 -0300, Tulio Magno Quites Machado Filho via Libstdc++ wrote:
>>>> I suggest to replace frexpf128 with __frexpieee128.
>>>>
>>>> The former is available on a glibc that support _Float128 (since glibc 2.26).
>>>> The later is available on a glibc that supports binary128 long double (since
>>>> glibc 2.32)
>>>
>>> Hmm, yes, you pointed me to __frexpieee128 a few months ago, but for
>>> some reason I either didn't switch to using it, or lost a patch when
>>> squashing and rebasing branches. Hopefully I just forgot to change it,
>>> but I'll double check to make sure I haven't left any work on an old
>>> branch. Thanks for suggesting it (again!)
>>
>> As expected, it still works with a check for __frexpieee128 instead.
>>
>> So are you happy for me to push this to master with that change?
>>
>> (It won't be until Tuesday now, as I have some time off).
>
>FYI, Tulio is on vacation through December 22nd and I'm not sure how
>closely he is watching his email, if at all. Given Tulio mentioned
>the change in the first place, I think he's ok with the change.
>He can beat me later if I'm wrong! :-)
The question was more about pushing the entire patch for ieee128
support, which isn't on master yet.
Do we want this done now for gcc 11? It adds a ton of new symbols to
libstdc++.so which would be a pain to remove again if we decide it's
not ready.
Currently the new features will be enabled by default if the support
is detected in the compiler and glibc. Do we want to gate it behind a
new --enable-something-something option? (I'm assuming not).
next prev parent reply other threads:[~2020-12-10 17:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 21:50 Jonathan Wakely
2020-11-30 21:30 ` Michael Meissner
2020-12-01 15:10 ` Jonathan Wakely
2020-12-01 16:04 ` Jonathan Wakely
2020-12-01 19:10 ` Michael Meissner
2020-12-01 21:10 ` Jonathan Wakely
2020-12-01 21:41 ` Jonathan Wakely
[not found] ` <20201201222501.GA18971@ibm-toto.the-meissners.org>
2020-12-01 22:36 ` Jonathan Wakely
2020-12-01 23:24 ` Michael Meissner
2020-12-02 15:14 ` Michael Meissner
2020-12-01 23:32 ` Michael Meissner
2020-12-03 23:07 ` Tulio Magno Quites Machado Filho
2020-12-04 0:35 ` Jonathan Wakely
2020-12-10 16:14 ` Jonathan Wakely
2020-12-10 17:14 ` Peter Bergner
2020-12-10 17:27 ` Jonathan Wakely [this message]
2020-12-15 0:57 ` Tulio Magno Quites Machado Filho
2020-11-30 23:29 ` Segher Boessenkool
2020-12-01 15:04 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210172719.GB2309743@redhat.com \
--to=jwakely@redhat.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=tuliom@ascii.art.br \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).