public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Piotr Kubaj <pkubaj@anongoth.pl>
Cc: gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
	Andreas Tobler <andreast@freebsd.org>
Subject: Re: rs6000: add support for powerpc64le-unknown-freebsd
Date: Mon, 14 Dec 2020 10:46:04 -0600	[thread overview]
Message-ID: <20201214164604.GR2672@gate.crashing.org> (raw)
In-Reply-To: <X9eGSvNaJ0ViqRUN@KGPE-D16>

Hi!

On Mon, Dec 14, 2020 at 04:35:38PM +0100, Piotr Kubaj wrote:
> this patch implements support for powerpc64le architecture on FreeBSD. Since we don't have powerpcle (32-bit), I did not add support for powerpcle here. This remains to be changed if there is powerpcle support in the future.
> 
> Patch implements similar endian detection to what linux64.h uses.
> 
> Would it be ok to backport it to at least GCC 10?

> --- gcc/config.gcc.orig	2020-12-07 03:00:29 UTC
> +++ gcc/config.gcc
> @@ -2868,6 +2868,10 @@ powerpc*-*-freebsd*)
>  	extra_options="${extra_options} rs6000/sysv4.opt"
>  	tmake_file="rs6000/t-fprules rs6000/t-ppcos ${tmake_file} rs6000/t-ppccomm"
>  	case ${target} in
> +	    powerpc*le-*-*)
> +		tm_file="${tm_file} rs6000/sysv4le.h" ;;
> +	esac

What an obvious filename ;-)

I guess we should put all these header files together into one again,
but that is hard to do without regressing things (I suspect this is
where the mystery power4 stems from as well, fwiw).

The patch looks fine.  Okay for trunk.  Also okay for any backports you
want (after waiting to see if it creates problems on trunk, as usual).

Thanks!


Segher

  reply	other threads:[~2020-12-14 16:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 15:35 Piotr Kubaj
2020-12-14 16:46 ` Segher Boessenkool [this message]
2020-12-14 23:29   ` Gerald Pfeifer
2020-12-15  0:30     ` Segher Boessenkool
2020-12-16 22:58     ` Segher Boessenkool
2020-12-28 11:44       ` Gerald Pfeifer
2020-12-28 12:37         ` Segher Boessenkool
2021-09-10 23:26           ` Piotr Kubaj
2020-12-14 23:37 ` Gerald Pfeifer
2020-12-14 23:52   ` Piotr Kubaj
2020-12-16 22:23     ` Segher Boessenkool
2021-04-29 11:37       ` Piotr Kubaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214164604.GR2672@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=andreast@freebsd.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pkubaj@anongoth.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).