From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
 by sourceware.org (Postfix) with ESMTP id DA4BC3854815
 for <gcc-patches@gcc.gnu.org>; Mon, 14 Dec 2020 16:48:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DA4BC3854815
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=kernel.crashing.org
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=segher@kernel.crashing.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
 by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 0BEGkAJS010312;
 Mon, 14 Dec 2020 10:46:10 -0600
Received: (from segher@localhost)
 by gate.crashing.org (8.14.1/8.14.1/Submit) id 0BEGk4Pk010303;
 Mon, 14 Dec 2020 10:46:04 -0600
X-Authentication-Warning: gate.crashing.org: segher set sender to
 segher@kernel.crashing.org using -f
Date: Mon, 14 Dec 2020 10:46:04 -0600
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Piotr Kubaj <pkubaj@anongoth.pl>
Cc: gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
 Andreas Tobler <andreast@freebsd.org>
Subject: Re: rs6000: add support for powerpc64le-unknown-freebsd
Message-ID: <20201214164604.GR2672@gate.crashing.org>
References: <X9eGSvNaJ0ViqRUN@KGPE-D16>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <X9eGSvNaJ0ViqRUN@KGPE-D16>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR,
 T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Dec 2020 16:48:17 -0000

Hi!

On Mon, Dec 14, 2020 at 04:35:38PM +0100, Piotr Kubaj wrote:
> this patch implements support for powerpc64le architecture on FreeBSD. Since we don't have powerpcle (32-bit), I did not add support for powerpcle here. This remains to be changed if there is powerpcle support in the future.
> 
> Patch implements similar endian detection to what linux64.h uses.
> 
> Would it be ok to backport it to at least GCC 10?

> --- gcc/config.gcc.orig	2020-12-07 03:00:29 UTC
> +++ gcc/config.gcc
> @@ -2868,6 +2868,10 @@ powerpc*-*-freebsd*)
>  	extra_options="${extra_options} rs6000/sysv4.opt"
>  	tmake_file="rs6000/t-fprules rs6000/t-ppcos ${tmake_file} rs6000/t-ppccomm"
>  	case ${target} in
> +	    powerpc*le-*-*)
> +		tm_file="${tm_file} rs6000/sysv4le.h" ;;
> +	esac

What an obvious filename ;-)

I guess we should put all these header files together into one again,
but that is hard to do without regressing things (I suspect this is
where the mystery power4 stems from as well, fwiw).

The patch looks fine.  Okay for trunk.  Also okay for any backports you
want (after waiting to see if it creates problems on trunk, as usual).

Thanks!


Segher