From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id E8A98385800D for ; Tue, 15 Dec 2020 10:26:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E8A98385800D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-RrmXxV0JN4aAVKLxsl3FqQ-1; Tue, 15 Dec 2020 05:26:35 -0500 X-MC-Unique: RrmXxV0JN4aAVKLxsl3FqQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1FCD81934101; Tue, 15 Dec 2020 10:26:34 +0000 (UTC) Received: from localhost (unknown [10.33.36.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9A30E100238C; Tue, 15 Dec 2020 10:26:33 +0000 (UTC) Date: Tue, 15 Dec 2020 10:26:32 +0000 From: Jonathan Wakely To: Marius Hillenbrand Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PING] [PATCH] testsuite/libstdc++: Fix required locales of a testcase Message-ID: <20201215102632.GH2309743@redhat.com> References: <20201124162625.30691-1-mhillen@linux.ibm.com> <87c28d3d-d7db-fa4c-91b5-ab1459acc0e5@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <87c28d3d-d7db-fa4c-91b5-ab1459acc0e5@linux.ibm.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 10:26:40 -0000 On 14/12/20 11:19 +0100, Marius Hillenbrand wrote: >I'd like to ping the small fixup in >https://gcc.gnu.org/pipermail/gcc-patches/2020-November/560100.html > >Please review and merge, if OK. Patches for libstdc++ need to be CC'd to the libstdc++ list, or I won't see them (this is mentioned at https://gcc.gnu.org/lists.html which https://gcc.gnu.org/contribute.html#patches links to). The patch itself is good, so I'll merge it today, thanks! >Marius > > >-------- Forwarded Message -------- >Subject: [PATCH] testsuite/libstdc++: Fix required locales of a testcase >Date: Tue, 24 Nov 2020 17:26:26 +0100 >From: Marius Hillenbrand >To: gcc-patches@gcc.gnu.org >CC: Marius Hillenbrand > >The testsuite for libstdc++ aims to skips test cases for which not all >required locales are installed. This patch adds missing directives about >required locales to one test case to avoid false positive test failures >on systems that have a partial set of locales installed. > >Verified by test suite runs that this patch changes the test case from >FAIL to UNSUPPORTED when not all required locales are available and that >the test case will run and PASS when the necessary locales have been >added. > >Please review and merge this patch if you agree. While this patch is >trivial, it may safe others a few minutes of confusion ;-) > >Marius > > >libstdc++-v3/ChangeLog: > >2020-11-24 Marius Hillenbrand > > * testsuite/22_locale/locale/cons/5.cc: Add missing directives > for required locales. >--- > libstdc++-v3/testsuite/22_locale/locale/cons/5.cc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc >b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc >index 8fd73960abb..49e863ec85c 100644 >--- a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc >+++ b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc >@@ -1,5 +1,7 @@ >-// { dg-require-namedlocale "en_PH" } > // { dg-require-namedlocale "de_DE" } >+// { dg-require-namedlocale "en_PH" } >+// { dg-require-namedlocale "es_MX" } >+// { dg-require-namedlocale "fr_FR" } > // { dg-require-namedlocale "it_IT" } > // 2000-09-13 Benjamin Kosnik >-- >2.26.2 >