public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Kwok Cheung Yeung <kcy@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] openmp: Implicit 'declare target' for C++ static initializers
Date: Fri, 18 Dec 2020 16:47:16 +0100	[thread overview]
Message-ID: <20201218154716.GA3788@tucnak> (raw)
In-Reply-To: <407ef40c-d808-1108-a9cc-2bd25f06c429@codesourcery.com>

On Fri, Dec 18, 2020 at 03:10:52PM +0000, Kwok Cheung Yeung wrote:
> --- a/gcc/cp/cp-lang.c
> +++ b/gcc/cp/cp-lang.c
> @@ -34,6 +34,8 @@ static tree cp_eh_personality (void);
>  static tree get_template_innermost_arguments_folded (const_tree);
>  static tree get_template_argument_pack_elems_folded (const_tree);
>  static tree cxx_enum_underlying_base_type (const_tree);
> +static tree * cxx_omp_get_decl_init (tree);

No space between * and cxx_omp_get_decl_init here.

> +extern tree * lhd_omp_get_decl_init (tree);

Ditto.

> +  /* Return a pointer to the tree representing the initializer
> +     expression for the non-local variable DECL.  Return NULL if
> +     DECL is not initialized.  */
> +  tree * (*omp_get_decl_init) (tree decl);

Ditto.

Ok for trunk with those nits fixed.

Thanks!

	Jakub


  reply	other threads:[~2020-12-18 15:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 14:20 Kwok Cheung Yeung
2020-10-29 10:03 ` Jakub Jelinek
2020-11-19 18:07   ` Kwok Cheung Yeung
2020-11-27 21:55     ` PING " Kwok Cheung Yeung
2020-12-08 16:24     ` Jakub Jelinek
2020-12-18 15:10       ` Kwok Cheung Yeung
2020-12-18 15:47         ` Jakub Jelinek [this message]
2020-12-18 19:31         ` Jakub Jelinek
2020-12-18 20:15           ` Kwok Cheung Yeung
2020-12-18 20:21             ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201218154716.GA3788@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kcy@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).