From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 412DD3857004 for ; Fri, 18 Dec 2020 19:29:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 412DD3857004 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-pPfyFfJwO4SlXICSsbNTCw-1; Fri, 18 Dec 2020 14:28:59 -0500 X-MC-Unique: pPfyFfJwO4SlXICSsbNTCw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39844107ACE6; Fri, 18 Dec 2020 19:28:58 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-11.ams2.redhat.com [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C76AA6A251; Fri, 18 Dec 2020 19:28:57 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 0BIJSsdP3400492 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Dec 2020 20:28:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 0BIJSroP3399336; Fri, 18 Dec 2020 20:28:53 +0100 Date: Fri, 18 Dec 2020 20:28:53 +0100 From: Jakub Jelinek To: Iain Sandoe Cc: GCC Patches Subject: [committed] libcc1: Fix up libcc1 configure [PR98330] Message-ID: <20201218192853.GG3788@tucnak> Reply-To: Jakub Jelinek References: <20201124104735.GB1312820@redhat.com> <8739298D-11AD-473A-A881-56A9DAAC9561@sandoe.co.uk> MIME-Version: 1.0 In-Reply-To: <8739298D-11AD-473A-A881-56A9DAAC9561@sandoe.co.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Level: **** X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2020 19:29:17 -0000 On Wed, Dec 02, 2020 at 04:11:24PM +0000, Iain Sandoe wrote: > > > --- a/libcc1/configure.ac > > > +++ b/libcc1/configure.ac > > > @@ -104,6 +104,12 @@ AC_CACHE_CHECK([for socket libraries], > > > libcc1_cv_lib_sockets, > > > ]) > > > LIBS="$LIBS $libcc1_cv_lib_sockets" > > > > > > +case "$host" in > > > + *-*-darwin*) darwin_dynamic_lookup=yes ;; > > > + *) darwin_dynamic_lookup= ;; > > > +esac > > > +AM_CONDITIONAL(DARWIN_DYNAMIC_LOOKUP, test $darwin_dynamic_lookup = yes) Either we should write test x$darwin_dynamic_lookup = xyes or we should make sure the variable is always defined to non-empty string. The following patch does the latter, committed to trunk as obvious. 2020-12-18 Jakub Jelinek PR bootstrap/98380 * configure.ac: Set darwin_dynamic_lookup=no instead to empty string. * configure: Regenerated. --- libcc1/configure.ac.jj 2020-12-06 10:51:32.555577671 +0100 +++ libcc1/configure.ac 2020-12-18 20:18:22.615201701 +0100 @@ -106,7 +106,7 @@ LIBS="$LIBS $libcc1_cv_lib_sockets" case "$host" in *-*-darwin*) darwin_dynamic_lookup=yes ;; - *) darwin_dynamic_lookup= ;; + *) darwin_dynamic_lookup=no ;; esac AM_CONDITIONAL(DARWIN_DYNAMIC_LOOKUP, test $darwin_dynamic_lookup = yes) --- libcc1/configure.jj 2020-12-06 10:51:32.555577671 +0100 +++ libcc1/configure 2020-12-18 20:18:30.373121348 +0100 @@ -14976,7 +14976,7 @@ LIBS="$LIBS $libcc1_cv_lib_sockets" case "$host" in *-*-darwin*) darwin_dynamic_lookup=yes ;; - *) darwin_dynamic_lookup= ;; + *) darwin_dynamic_lookup=no ;; esac if test $darwin_dynamic_lookup = yes; then DARWIN_DYNAMIC_LOOKUP_TRUE= Jakub