From: Jakub Jelinek <jakub@redhat.com>
To: Kwok Cheung Yeung <kcy@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] openmp: Implicit 'declare target' for C++ static initializers
Date: Fri, 18 Dec 2020 21:21:42 +0100 [thread overview]
Message-ID: <20201218202142.GI3788@tucnak> (raw)
In-Reply-To: <a13538c4-f5f9-6a7a-34cf-1c3e862804ad@codesourcery.com>
On Fri, Dec 18, 2020 at 08:15:56PM +0000, Kwok Cheung Yeung wrote:
> On 18/12/2020 7:31 pm, Jakub Jelinek wrote:
> > On Fri, Dec 18, 2020 at 03:10:52PM +0000, Kwok Cheung Yeung wrote:
> > > 2020-12-17 Kwok Cheung Yeung <kcy@codesourcery.com>
> > >
> > > gcc/testsuite/
> > > * g++.dg/gomp/declare-target-3.C: New.
> >
> > Note the test fails on the trunk when one doesn't have offloading
> > configured. IL scan tests are always problematic, different between
> > offloading and no offloading...
>
> Oops. This patch disables the scan for .offload_var_table entries in the
> assembler if offloading is not enabled. The gimple tests appear to be okay
> though?
>
> Okay for trunk?
Ok, thanks.
> commit f427d4eaddbd1ee4001e057b231c92fdd9fc66f5
> Author: Kwok Cheung Yeung <kcy@codesourcery.com>
> Date: Fri Dec 18 12:05:20 2020 -0800
>
> openmp: Fix g++.dg/gomp/declare-target-3.C testcase when offloading is disabled
>
> 2020-12-18 Kwok Cheung Yeung <kcy@codesourcery.com>
>
> gcc/testsuite/
> * g++.dg/gomp/declare-target-3.C: Only check .offload_var_table
> entries if offloading is enabled.
Jakub
prev parent reply other threads:[~2020-12-18 20:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 14:20 Kwok Cheung Yeung
2020-10-29 10:03 ` Jakub Jelinek
2020-11-19 18:07 ` Kwok Cheung Yeung
2020-11-27 21:55 ` PING " Kwok Cheung Yeung
2020-12-08 16:24 ` Jakub Jelinek
2020-12-18 15:10 ` Kwok Cheung Yeung
2020-12-18 15:47 ` Jakub Jelinek
2020-12-18 19:31 ` Jakub Jelinek
2020-12-18 20:15 ` Kwok Cheung Yeung
2020-12-18 20:21 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218202142.GI3788@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kcy@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).