public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Jakub Jelinek <jakub@redhat.com>,
	Ian Lance Taylor <iant@golang.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	Jonathan Wakely <jwakely.gcc@gmail.com>
Subject: Re: Patch RFA: Support non-ASCII file names in git-changelog
Date: Thu, 24 Dec 2020 16:16:38 +0400	[thread overview]
Message-ID: <20201224121638.GL353421@adacore.com> (raw)
In-Reply-To: <64528957-cf87-676a-70cd-7fdd5bfeaf17@suse.cz>

> > I have no idea who that is (if it is a single user at all,
> > if it isn't any user with git write permissions).
> 
> CCing Joel, he should help us how to set a git config
> that will be used by the server hooks.

I am not sure that requiring both the server and the user to agree
on a non-default configuration value would be a practical idea.

From what I understand of the problem, I think the proper fix
is really to adapt the git-changelog script to avoid the need
for any assumption about the user's configuration. In particular,
how does the script get the list of files? Poking around, it looks like
you guys are using the GitPython module, which I'm not familiar with,
unfortunately.  But as a reference point, the git-hooks simply use
the -z option to get the information in raw format, and thus avoids
the problem of filename quoting entirely. Does GitPython support
something similar? For instance, browing the GitPython documentation,
I found attributes a_raw_path and b_raw_path. Could that be the
solution (instead of using a_path and b_path?

Either way, the solution will be independent of the git-hooks,
as I don't think they are actually involved, here.

-- 
Joel

  reply	other threads:[~2020-12-24 12:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  4:26 Ian Lance Taylor
2020-12-18 10:28 ` Martin Liška
2020-12-18 18:30   ` Ian Lance Taylor
2020-12-21  9:39     ` Martin Liška
2020-12-21  9:48       ` Jakub Jelinek
2020-12-21  9:57         ` Martin Liška
2020-12-24 12:16           ` Joel Brobecker [this message]
2021-01-04 11:01             ` Martin Liška
2021-01-04 11:47               ` Martin Liška
2021-01-06  7:25                 ` Martin Liška
2021-01-06 13:37                   ` Martin Liška
2021-01-07 19:03                     ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201224121638.GL353421@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@golang.org \
    --cc=jakub@redhat.com \
    --cc=jwakely.gcc@gmail.com \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).