From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 86B76386181F for ; Mon, 4 Jan 2021 21:00:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 86B76386181F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-qSLdCsjGO02fqRaqHYJrWw-1; Mon, 04 Jan 2021 16:00:23 -0500 X-MC-Unique: qSLdCsjGO02fqRaqHYJrWw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96A1859; Mon, 4 Jan 2021 21:00:22 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-11.ams2.redhat.com [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B1285D735; Mon, 4 Jan 2021 21:00:22 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 104L0Ja9725559 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 4 Jan 2021 22:00:19 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 104L0IrI725558; Mon, 4 Jan 2021 22:00:18 +0100 Date: Mon, 4 Jan 2021 22:00:18 +0100 From: Jakub Jelinek To: Jeff Law Cc: Xi Ruoyao , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] MIPS: Fix PR target/98491 (ChangeLog) Message-ID: <20210104210018.GD725145@tucnak> Reply-To: Jakub Jelinek References: <4df733093ede4a3cc5dcb2688dcc9a2e5be4b721.camel@mengyan1223.wang> <184fa89ee34af9c3b13e99513a10aed1bd7c88af.camel@mengyan1223.wang> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2021 21:00:26 -0000 On Mon, Jan 04, 2021 at 01:51:59PM -0700, Jeff Law via Gcc-patches wrote: > > Sorry, I forgot to include the ChangeLog: > > > > gcc/ChangeLog: > > > > 2020-12-31 Xi Ruoyao > > > > PR target/98491 > > * config/mips/mips.c (mips_symbol_insns): Do not use > > MSA_SUPPORTED_MODE_P if mode is MAX_MACHINE_MODE. > So I absolutely agree the current code is wrong as it does an out of > bounds array access. > > > Would it be better to instead to change MSA_SUPPORTED_MODE_P to evaluate > to zero if MODE is MAX_MACHINE_MODE?  That would protect all the uses of > MSA_SUPPORTED_MODE_P.    Something like this perhaps? But MAX_MACHINE_MODE is the one past last valid mode, I'm not aware of any target that would protect all macros that deal with modes that way. So, perhaps best would be stop using the MAX_MACHINE_MODE as magic value for that function and instead use say VOIDmode that shouldn't normally appear either? But I don't really see anything wrong on the mips_symbol_insns above change either. Jakub