From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 8CECF384241B for ; Thu, 7 Jan 2021 21:37:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8CECF384241B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-MTjh0jRxPheGM_pbVvxNoA-1; Thu, 07 Jan 2021 16:37:06 -0500 X-MC-Unique: MTjh0jRxPheGM_pbVvxNoA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63559190A7A1; Thu, 7 Jan 2021 21:37:05 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-11.ams2.redhat.com [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED52260BF1; Thu, 7 Jan 2021 21:37:04 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 107Lb2513938011 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 7 Jan 2021 22:37:03 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 107Lb2843936212; Thu, 7 Jan 2021 22:37:02 +0100 Date: Thu, 7 Jan 2021 22:37:02 +0100 From: Jakub Jelinek To: Martin Sebor Cc: gcc-patches Subject: Re: [committed] fix another ICE in MEM_REF formatting (PR 98578) Message-ID: <20210107213702.GQ725145@tucnak> Reply-To: Jakub Jelinek References: <12069778-e6af-6fb9-13d4-a3c555c70a29@gmail.com> MIME-Version: 1.0 In-Reply-To: <12069778-e6af-6fb9-13d4-a3c555c70a29@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2021 21:37:09 -0000 On Thu, Jan 07, 2021 at 02:29:50PM -0700, Martin Sebor via Gcc-patches wrote: > --- a/gcc/c-family/c-pretty-print.c > +++ b/gcc/c-family/c-pretty-print.c > @@ -1844,22 +1844,25 @@ print_mem_ref (c_pretty_printer *pp, tree e) > } > } > > - const tree access_type = TREE_TYPE (e); > + tree access_type = TREE_TYPE (e); > + if (TREE_CODE (access_type) == ARRAY_TYPE) > + access_type = TREE_TYPE (access_type); > tree arg_type = TREE_TYPE (TREE_TYPE (arg)); > if (TREE_CODE (arg_type) == ARRAY_TYPE) > arg_type = TREE_TYPE (arg_type); The array types can be multidimensional, are you sure you don't want to use strip_array_types instead? Jakub