From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 40E86388A437; Thu, 21 Jan 2021 23:49:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 40E86388A437 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 10LNmvNf027235; Thu, 21 Jan 2021 17:48:57 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 10LNmvp6027227; Thu, 21 Jan 2021 17:48:57 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 21 Jan 2021 17:48:57 -0600 From: Segher Boessenkool To: Xionghu Luo Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, wschmidt@linux.ibm.com, guojiufu@linux.ibm.com, linkw@gcc.gnu.org Subject: Re: [PATCH 3/4] rs6000: Enable vec_insert for P8 with rs6000_expand_vector_set_var_p8 Message-ID: <20210121234857.GL30983@gate.crashing.org> References: <20201010080825.3599892-1-luoxhu@linux.ibm.com> <20201010080825.3599892-4-luoxhu@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201010080825.3599892-4-luoxhu@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_NUMSUBJECT, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2021 23:49:59 -0000 Hi! You never committed 2/4? That makes it harder to review this one :-) On Sat, Oct 10, 2020 at 03:08:24AM -0500, Xionghu Luo wrote: > gcc/ChangeLog: > > 2020-10-10 Xionghu Luo > > * config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin): > Generate ARRAY_REF(VIEW_CONVERT_EXPR) for P8 and later > platforms. > * config/rs6000/rs6000.c (rs6000_expand_vector_set_var): Update > to call different path for P8 and P9. > (rs6000_expand_vector_set_var_p9): New function. > (rs6000_expand_vector_set_var_p8): New function. > > gcc/testsuite/ChangeLog: > > 2020-10-10 Xionghu Luo > > * gcc.target/powerpc/pr79251.p8.c: New test. If testing on P9 LE and P7 BE (32-bit and 64-bit) worked, this is okay for trunk. Thanks! (Let me know if you need help testing.) Segher