From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alan Modra <amodra@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 4/8] [RS6000] rs6000_rtx_costs tidy break/return
Date: Mon, 25 Jan 2021 16:40:15 -0600 [thread overview]
Message-ID: <20210125224015.GB30983@gate.crashing.org> (raw)
In-Reply-To: <20201007225800.9536-5-amodra@gmail.com>
On Thu, Oct 08, 2020 at 09:27:56AM +1030, Alan Modra wrote:
> Most cases use "return false" rather than breaking out of the switch.
> Do so in all cases.
> default:
> - break;
> + return false;
> }
> -
> - return false;
> }
Please don't do this part. The rest is okay. Thanks!
Segher
next prev parent reply other threads:[~2021-01-25 22:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 22:57 [PATCH 0/8] [RS6000] rs6000_rtx_costs V2 Alan Modra
2020-10-07 22:57 ` [PATCH 1/8] [RS6000] rs6000_rtx_costs comment Alan Modra
2020-10-14 20:08 ` Segher Boessenkool
2020-10-07 22:57 ` [PATCH 2/8] [RS6000] rs6000_rtx_costs for AND Alan Modra
2020-10-20 18:55 ` Segher Boessenkool
2020-10-21 2:57 ` Alan Modra
2020-10-21 20:29 ` Segher Boessenkool
2020-10-21 22:11 ` Alan Modra
2020-10-22 13:29 ` Segher Boessenkool
2020-10-23 23:18 ` Hans-Peter Nilsson
2020-10-24 1:04 ` Alan Modra
2020-10-07 22:57 ` [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND Alan Modra
[not found] ` <20210112033157.GA26219@bubble.grove.modra.org>
2021-01-21 23:09 ` Alan Modra
2021-01-25 22:37 ` Segher Boessenkool
2021-02-01 2:06 ` Alan Modra
2020-10-07 22:57 ` [PATCH 4/8] [RS6000] rs6000_rtx_costs tidy break/return Alan Modra
[not found] ` <20210112033209.GB26219@bubble.grove.modra.org>
2021-01-21 23:09 ` Alan Modra
2021-01-25 22:40 ` Segher Boessenkool [this message]
2020-10-07 22:57 ` [PATCH 5/8] [RS6000] rs6000_rtx_costs cost IOR Alan Modra
[not found] ` <20210112033218.GC26219@bubble.grove.modra.org>
2021-01-21 23:10 ` Alan Modra
2021-01-25 22:51 ` Segher Boessenkool
2021-02-01 2:13 ` Alan Modra
2020-10-07 22:57 ` [PATCH 6/8] [RS6000] rs6000_rtx_costs multi-insn constants Alan Modra
2020-10-07 22:57 ` [PATCH 7/8] [RS6000] rs6000_rtx_costs reduce cost for SETs Alan Modra
2020-10-08 18:19 ` will schmidt
[not found] ` <20210112033227.GD26219@bubble.grove.modra.org>
2021-01-21 23:10 ` Alan Modra
2020-10-07 22:58 ` [PATCH 8/8] [RS6000] rs6000_rtx_costs for !speed Alan Modra
[not found] ` <20210112033236.GE26219@bubble.grove.modra.org>
2021-01-21 23:11 ` Alan Modra
2020-12-05 9:12 ` [PATCH 0/8] [RS6000] rs6000_rtx_costs V2 Alan Modra
2021-01-11 21:42 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125224015.GB30983@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).