From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 26C3B3854802 for ; Thu, 28 Jan 2021 03:12:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 26C3B3854802 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 10S3Bols018957; Wed, 27 Jan 2021 21:11:50 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 10S3BnrD018956; Wed, 27 Jan 2021 21:11:49 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 27 Jan 2021 21:11:49 -0600 From: Segher Boessenkool To: Michael Meissner , gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt , Peter Bergner Subject: Re: [Ping] PowerPC: Add float128/Decimal conversions. Message-ID: <20210128031149.GN30983@gate.crashing.org> References: <20210114170936.GA3319@ibm-toto.the-meissners.org> <20210126234306.GB13187@ibm-toto.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126234306.GB13187@ibm-toto.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_SHORT, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 03:12:53 -0000 On Tue, Jan 26, 2021 at 06:43:06PM -0500, Michael Meissner wrote: > I posted this patch on January 14th, 2021: > https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563498.html > > | Date: Thu, 14 Jan 2021 12:09:36 -0500 > | Subject: [PATCH] PowerPC: Add float128/Decimal conversions. > | Message-ID: <20210114170936.GA3319@ibm-toto.the-meissners.org> > > You had a question about what changed, and I replied: > > | In your last message, you said that it was unacceptable that the conversion > | fails if the user uses an old GLIBC. So I rewrote the code using weak > | references. If the user has at least GLIBC 2.32, it will use the IEEE 128-bit > | string support in the library. > | > | If an older GLIBC is used, I then use the IBM 128-bit format as an intermediate > | value. Obviously there are cases where IEEE 128-bit can hold values that IBM > | 128-bit can't (mostly due to the increased exponent range in IEEE 128-bit), but > | it at least does the conversion for the numbers in the common range. > | > | In doing this transformation, I needed to do minor edits to the main decimal > | to/from binary conversion functions to allow the KF functions to be declared. > | Previously, I used preprocessor magic to rename the functions. > > This is the second most important patch in the IEEE 128-bit work. What do I > need to do to be able to commit the patch? The whole thread is at https://patchwork.ozlabs.org/project/gcc/patch/20201120000524.GA903@ibm-toto.the-meissners.org/ . I approved *that* version of the patch. Segher