From: Alan Modra <amodra@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND
Date: Mon, 1 Feb 2021 12:36:16 +1030 [thread overview]
Message-ID: <20210201020616.GC26219@bubble.grove.modra.org> (raw)
In-Reply-To: <20210125223721.GA30983@gate.crashing.org>
On Mon, Jan 25, 2021 at 04:37:21PM -0600, Segher Boessenkool wrote:
> I still do not see what this improves, I only see possible obvious
> regressions :-(
You asked me to break the patch series into small pieces, for ease of
review and to separate tidies from functional changes. Well OK, fair
enough. This is one of the tidies. The idea being to make
rs6000_rtx_costs a little more self-consistent, to not have someone
look at this code in the future and wonder why AND was treated
differently to other operations.
The only part of this patch that I can imagine you see as a possible
regression is the "Don't avoid recursion on const_int shift count"
part. That is there only because you wanted it that way in new code.
I think you said something about premature optimisation when I made
the new code special case const_int and reg to stop recursion, like
AND. So for consistency I made the change in old code too.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2021-02-01 2:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 22:57 [PATCH 0/8] [RS6000] rs6000_rtx_costs V2 Alan Modra
2020-10-07 22:57 ` [PATCH 1/8] [RS6000] rs6000_rtx_costs comment Alan Modra
2020-10-14 20:08 ` Segher Boessenkool
2020-10-07 22:57 ` [PATCH 2/8] [RS6000] rs6000_rtx_costs for AND Alan Modra
2020-10-20 18:55 ` Segher Boessenkool
2020-10-21 2:57 ` Alan Modra
2020-10-21 20:29 ` Segher Boessenkool
2020-10-21 22:11 ` Alan Modra
2020-10-22 13:29 ` Segher Boessenkool
2020-10-23 23:18 ` Hans-Peter Nilsson
2020-10-24 1:04 ` Alan Modra
2020-10-07 22:57 ` [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND Alan Modra
[not found] ` <20210112033157.GA26219@bubble.grove.modra.org>
2021-01-21 23:09 ` Alan Modra
2021-01-25 22:37 ` Segher Boessenkool
2021-02-01 2:06 ` Alan Modra [this message]
2020-10-07 22:57 ` [PATCH 4/8] [RS6000] rs6000_rtx_costs tidy break/return Alan Modra
[not found] ` <20210112033209.GB26219@bubble.grove.modra.org>
2021-01-21 23:09 ` Alan Modra
2021-01-25 22:40 ` Segher Boessenkool
2020-10-07 22:57 ` [PATCH 5/8] [RS6000] rs6000_rtx_costs cost IOR Alan Modra
[not found] ` <20210112033218.GC26219@bubble.grove.modra.org>
2021-01-21 23:10 ` Alan Modra
2021-01-25 22:51 ` Segher Boessenkool
2021-02-01 2:13 ` Alan Modra
2020-10-07 22:57 ` [PATCH 6/8] [RS6000] rs6000_rtx_costs multi-insn constants Alan Modra
2020-10-07 22:57 ` [PATCH 7/8] [RS6000] rs6000_rtx_costs reduce cost for SETs Alan Modra
2020-10-08 18:19 ` will schmidt
[not found] ` <20210112033227.GD26219@bubble.grove.modra.org>
2021-01-21 23:10 ` Alan Modra
2020-10-07 22:58 ` [PATCH 8/8] [RS6000] rs6000_rtx_costs for !speed Alan Modra
[not found] ` <20210112033236.GE26219@bubble.grove.modra.org>
2021-01-21 23:11 ` Alan Modra
2020-12-05 9:12 ` [PATCH 0/8] [RS6000] rs6000_rtx_costs V2 Alan Modra
2021-01-11 21:42 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201020616.GC26219@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).