From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.eu.adacore.com (mel.act-europe.fr [194.98.77.210]) by sourceware.org (Postfix) with ESMTPS id C0433385141E for ; Fri, 5 Feb 2021 13:59:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C0433385141E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=charlet@eu.adacore.com Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 845B982461; Fri, 5 Feb 2021 14:59:25 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at eu.adacore.com Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LbqYk1YvJupT; Fri, 5 Feb 2021 14:59:25 +0100 (CET) Received: from chelles.localdomain (chelles.act-europe.fr [10.10.0.160]) by smtp.eu.adacore.com (Postfix) with ESMTP id 5853A823DB; Fri, 5 Feb 2021 14:59:25 +0100 (CET) Received: by chelles.localdomain (Postfix, from userid 525) id 5446C1EA007F; Fri, 5 Feb 2021 14:59:25 +0100 (CET) Date: Fri, 5 Feb 2021 14:59:25 +0100 From: Arnaud Charlet To: Mikael Pettersson Cc: GCC Patches , Arnaud Charlet Subject: Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590) Message-ID: <20210205135925.GA5737@adacore.com> References: <20210205083527.GA6784@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2021 13:59:27 -0000 > > We'd rather not have PR references in the source files, so please remove it > > (it will be there as part of the commit log and git annotate). > > > > OK with the comment updated. > > Thanks, here's the revised patch. OK, thanks. > gcc/ada/ > > 2021-02-05 Mikael Pettersson > > PR bootstrap/98590 > * cstreams.c: Ensure fileno_unlocked() is visible on Cygwin. > > diff --git a/gcc/ada/cstreams.c b/gcc/ada/cstreams.c > index 4e00dedbbd6..7d64277110b 100644 > --- a/gcc/ada/cstreams.c > +++ b/gcc/ada/cstreams.c > @@ -37,6 +37,11 @@ > #define _FILE_OFFSET_BITS 64 > /* the define above will make off_t a 64bit type on GNU/Linux */ > > +/* tell Cygwin's to expose fileno_unlocked() */ > +#if defined(__CYGWIN__) && !defined(__CYGWIN32__) && !defined(_GNU_SOURCE) > +#define _GNU_SOURCE > +#endif > + > #include > #include > #include