public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@axis.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Bernd Edlinger <bernd.edlinger@hotmail.de>
Subject: Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target"
Date: Tue, 16 Feb 2021 02:33:33 +0100	[thread overview]
Message-ID: <20210216013333.6B96C203D4@pchp3.se.axis.com> (raw)
In-Reply-To: <AM0PR0602MB34107E975575230D18E83525E4AE0@AM0PR0602MB3410.eurprd06.prod.outlook.com> (message from Bernd Edlinger on Fri, 8 Jan 2021 19:59:38 +0100)

Committed as obvious.  Please be more careful; this typo
should have been obvious in "make check" output as below.

Commit-log:
-------------------------------
Fix typo for istarget in "is_target hppa*-*-hpux*", yielding
an error running the test-suite for any target not matching
powerpc*-*-aix* (presumably, by code inspection), aborting
the check-gcc (check-gcc-c) regression test run some 3000
tests before the last one, missing e.g. all gcc.target
tests like so:

-----
...
Running /x/gcc/gcc/testsuite/gcc.misc-tests/outputs.exp ...
ERROR: (DejaGnu) proc "is_target hppa*-*-hpux*" does not exist.
The error code is TCL LOOKUP COMMAND is_target
The info on the error is:
invalid command name "is_target"
    while executing
"::tcl_unknown is_target hppa*-*-hpux*"
    ("uplevel" body line 1)
    invoked from within
"uplevel 1 ::tcl_unknown $args"

		=== gcc Summary ===
...
-----

gcc/testsuite:
	* gcc.misc-tests/outputs.exp (outest): Fix typo "is_target".
---
 gcc/testsuite/gcc.misc-tests/outputs.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp
index d5a9709910c2..4d904bde31d5 100644
--- a/gcc/testsuite/gcc.misc-tests/outputs.exp
+++ b/gcc/testsuite/gcc.misc-tests/outputs.exp
@@ -192,7 +192,7 @@ proc outest { test sources opts dirs outputs } {
 	# collect2 may create <execname>.cdtor* files in -save-temps link tests,
 	# ??? without regard to aux output naming conventions.
 	# Limit this exception to targets that define EH_FRAME_THROUGH_COLLECT2.
-	if { !(([istarget powerpc*-*-aix*] || [is_target hppa*-*-hpux*])
+	if { !(([istarget powerpc*-*-aix*] || [istarget hppa*-*-hpux*])
 	       && ([string match "*.cdtor.*" $f]
 		   || [string match "*.gcc_args" $f])) } {
 	    lappend outb $f
-- 
2.11.0

brgds, H-P

  parent reply	other threads:[~2021-02-16  1:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  8:48 [PATCH] Fix test failures from outputs.exp (PR testsuite/98225) Bernd Edlinger
2021-01-07 16:12 ` Rainer Orth
2021-01-07 22:18   ` [PATCH] testsuite: Fix test failures from outputs.exp [PR98225] Bernd Edlinger
2021-01-08  8:52     ` Alexandre Oliva
2021-01-11 12:11       ` Rainer Orth
2021-01-08 14:23     ` David Edelsohn
2021-01-08 18:59       ` [PATCH v2] " Bernd Edlinger
2021-01-08 19:27         ` David Edelsohn
2021-01-11 11:13           ` Bernd Edlinger
2021-01-11 12:13             ` Rainer Orth
2021-02-16  1:33         ` Hans-Peter Nilsson [this message]
2021-02-16  7:35           ` Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target" Bernd Edlinger
2021-02-16 10:48             ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210216013333.6B96C203D4@pchp3.se.axis.com \
    --to=hp@axis.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).