From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id D916A3858001 for ; Tue, 16 Feb 2021 01:33:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D916A3858001 From: Hans-Peter Nilsson To: CC: Bernd Edlinger In-Reply-To: (message from Bernd Edlinger on Fri, 8 Jan 2021 19:59:38 +0100) Subject: Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target" MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: Message-ID: <20210216013333.6B96C203D4@pchp3.se.axis.com> Date: Tue, 16 Feb 2021 02:33:33 +0100 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 01:33:38 -0000 Committed as obvious. Please be more careful; this typo should have been obvious in "make check" output as below. Commit-log: ------------------------------- Fix typo for istarget in "is_target hppa*-*-hpux*", yielding an error running the test-suite for any target not matching powerpc*-*-aix* (presumably, by code inspection), aborting the check-gcc (check-gcc-c) regression test run some 3000 tests before the last one, missing e.g. all gcc.target tests like so: ----- ... Running /x/gcc/gcc/testsuite/gcc.misc-tests/outputs.exp ... ERROR: (DejaGnu) proc "is_target hppa*-*-hpux*" does not exist. The error code is TCL LOOKUP COMMAND is_target The info on the error is: invalid command name "is_target" while executing "::tcl_unknown is_target hppa*-*-hpux*" ("uplevel" body line 1) invoked from within "uplevel 1 ::tcl_unknown $args" === gcc Summary === ... ----- gcc/testsuite: * gcc.misc-tests/outputs.exp (outest): Fix typo "is_target". --- gcc/testsuite/gcc.misc-tests/outputs.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp index d5a9709910c2..4d904bde31d5 100644 --- a/gcc/testsuite/gcc.misc-tests/outputs.exp +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp @@ -192,7 +192,7 @@ proc outest { test sources opts dirs outputs } { # collect2 may create .cdtor* files in -save-temps link tests, # ??? without regard to aux output naming conventions. # Limit this exception to targets that define EH_FRAME_THROUGH_COLLECT2. - if { !(([istarget powerpc*-*-aix*] || [is_target hppa*-*-hpux*]) + if { !(([istarget powerpc*-*-aix*] || [istarget hppa*-*-hpux*]) && ([string match "*.cdtor.*" $f] || [string match "*.gcc_args" $f])) } { lappend outb $f -- 2.11.0 brgds, H-P