From: Jakub Jelinek <jakub@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: Richard Biener <rguenther@suse.de>,
Martin Sebor <msebor@gmail.com>, Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] middle-end/97855 - fix diagnostic with default pretty printer
Date: Wed, 3 Mar 2021 19:02:55 +0100 [thread overview]
Message-ID: <20210303180255.GJ4020736@tucnak> (raw)
In-Reply-To: <df8140d9eabab2cc6093c2e411847b02c217e3c0.camel@redhat.com>
On Wed, Mar 03, 2021 at 12:45:54PM -0500, David Malcolm wrote:
> > I think it's the D.6750 which is printed via
> >
> > else if (TREE_CODE (node) == DEBUG_EXPR_DECL)
> > {
> > if (flags & TDF_NOUID)
> > pp_string (pp, "D#xxxx");
> > else
> > pp_printf (pp, "D#%i", DEBUG_TEMP_UID (node));
> >
> > because this is a DECL_DEBUG_EXPR.
>
> Wouldn't that print
> D#6750
> rather than
> D.6750
Sure. The D.6750 case is a few lines later:
pp_printf (pp, "%c%c%u", c, uid_sep, DECL_UID (node));
so we'd use
pp_character (pp, c);
pp_character (pp, uid_sep);
pp_decimal_int (pp, DECL_UID (node));
for that one.
Jakub
next prev parent reply other threads:[~2021-03-03 18:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 8:39 Richard Biener
2021-03-02 16:52 ` Jeff Law
2021-03-02 20:36 ` Martin Sebor
2021-03-03 7:48 ` Richard Biener
2021-03-03 15:00 ` David Malcolm
2021-03-03 15:23 ` Richard Biener
2021-03-03 15:52 ` Jakub Jelinek
2021-03-03 17:45 ` David Malcolm
2021-03-03 18:02 ` Jakub Jelinek [this message]
2021-03-04 8:39 ` Richard Biener
2021-03-04 12:24 ` Richard Biener
2021-03-04 14:20 ` David Malcolm
2021-03-04 14:21 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303180255.GJ4020736@tucnak \
--to=jakub@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=msebor@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).