From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B103B393C868 for ; Thu, 11 Mar 2021 16:31:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B103B393C868 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-_548HstrOFOCmTppYbhdag-1; Thu, 11 Mar 2021 11:31:53 -0500 X-MC-Unique: _548HstrOFOCmTppYbhdag-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53B381084D68; Thu, 11 Mar 2021 16:31:52 +0000 (UTC) Received: from localhost (unknown [10.33.36.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0E5A5D6D7; Thu, 11 Mar 2021 16:31:51 +0000 (UTC) Date: Thu, 11 Mar 2021 16:31:51 +0000 From: Jonathan Wakely To: Caroline Tice Cc: GCC Patches , libstdc++@gcc.gnu.org Subject: Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172] Message-ID: <20210311163151.GD3008@redhat.com> References: <20210311162756.GC3008@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210311162756.GC3008@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 16:31:58 -0000 On 11/03/21 16:27 +0000, Jonathan Wakely wrote: >That seems cleaner to me, rather than adding another variable with >minor differences from the existing AM_CXXFLAGS. My specific concern is that AM_CXXFLAGS and AM_CXXFLAGS_LT will get out of sync, i.e. we'll add something to the former and forget to add it to the latter. If we keep using AM_CXXFLAGS but cancel out the -fvtable-verify=std option, then there aren't two separate variables that can diverge. But I think it's too late in the gcc-11 process for that kind of refactoring.