From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Caroline Tice <cmtice@google.com>,
libstdc++@gcc.gnu.org, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]
Date: Thu, 11 Mar 2021 17:46:49 +0100 [thread overview]
Message-ID: <20210311164649.GK745611@tucnak> (raw)
In-Reply-To: <20210311163151.GD3008@redhat.com>
On Thu, Mar 11, 2021 at 04:31:51PM +0000, Jonathan Wakely via Gcc-patches wrote:
> On 11/03/21 16:27 +0000, Jonathan Wakely wrote:
> > That seems cleaner to me, rather than adding another variable with
> > minor differences from the existing AM_CXXFLAGS.
>
> My specific concern is that AM_CXXFLAGS and AM_CXXFLAGS_LT will get
> out of sync, i.e. we'll add something to the former and forget to add
> it to the latter.
>
> If we keep using AM_CXXFLAGS but cancel out the -fvtable-verify=std
> option, then there aren't two separate variables that can diverge.
>
> But I think it's too late in the gcc-11 process for that kind of
> refactoring.
I think $(filter-out -fvtable-verify=std,$(AM_CXXFLAGS)) should be fairly
simple thing if that is all that needs to be done.
Jakub
next prev parent reply other threads:[~2021-03-11 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 4:50 Caroline Tice
2021-03-11 15:31 ` Caroline Tice
2021-03-11 16:27 ` Jonathan Wakely
2021-03-11 16:31 ` Jonathan Wakely
2021-03-11 16:46 ` Jakub Jelinek [this message]
2021-03-11 17:10 ` Jonathan Wakely
2021-03-12 23:33 ` Caroline Tice
2021-03-15 12:28 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311164649.GK745611@tucnak \
--to=jakub@redhat.com \
--cc=cmtice@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).