From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 932C43861828 for ; Thu, 11 Mar 2021 16:46:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 932C43861828 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-9_Vr2fpXNV6Vm-VC1hCqmQ-1; Thu, 11 Mar 2021 11:46:55 -0500 X-MC-Unique: 9_Vr2fpXNV6Vm-VC1hCqmQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ED7A2881DEC; Thu, 11 Mar 2021 16:46:52 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-238.ams2.redhat.com [10.36.113.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89C885C1CF; Thu, 11 Mar 2021 16:46:52 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 12BGkntf3940346 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 11 Mar 2021 17:46:50 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 12BGknVA3940345; Thu, 11 Mar 2021 17:46:49 +0100 Date: Thu, 11 Mar 2021 17:46:49 +0100 From: Jakub Jelinek To: Jonathan Wakely Cc: Caroline Tice , libstdc++@gcc.gnu.org, GCC Patches Subject: Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172] Message-ID: <20210311164649.GK745611@tucnak> Reply-To: Jakub Jelinek References: <20210311162756.GC3008@redhat.com> <20210311163151.GD3008@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210311163151.GD3008@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 16:46:58 -0000 On Thu, Mar 11, 2021 at 04:31:51PM +0000, Jonathan Wakely via Gcc-patches wrote: > On 11/03/21 16:27 +0000, Jonathan Wakely wrote: > > That seems cleaner to me, rather than adding another variable with > > minor differences from the existing AM_CXXFLAGS. > > My specific concern is that AM_CXXFLAGS and AM_CXXFLAGS_LT will get > out of sync, i.e. we'll add something to the former and forget to add > it to the latter. > > If we keep using AM_CXXFLAGS but cancel out the -fvtable-verify=std > option, then there aren't two separate variables that can diverge. > > But I think it's too late in the gcc-11 process for that kind of > refactoring. I think $(filter-out -fvtable-verify=std,$(AM_CXXFLAGS)) should be fairly simple thing if that is all that needs to be done. Jakub