From: Jakub Jelinek <jakub@redhat.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org, Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] testsuite: Disable zero-scratch-regs-{8,9,10,11}.c on s390* [PR97680]
Date: Wed, 31 Mar 2021 09:02:36 +0200 [thread overview]
Message-ID: <20210331070236.GO1179226@tucnak> (raw)
In-Reply-To: <5697441.lOV4Wx5bFT@fomalhaut>
On Wed, Mar 31, 2021 at 08:01:29AM +0200, Eric Botcazou wrote:
> > It looks like the latter - I've seen no attempt by the original authors to
> > make the feature work on more targets than they cared for.
>
> On the other hand, if you hide the failures, there is essentially zero chance
> that architecture maintainers pick up the pieces (I personally implemented the
> SPARC support only because I had ran into the failures in the testsuite). So
> doing the inverse filtering sounds quite counterproductive to me and IMO it's
> up to the architecture maintainers to decide on a case-by-case basis.
That is true, but nothing really happened during the 5 months that the tests
have been failing on many other architectures (except that powerpc and arm
had skipped those tests). There has been a PR open for all those 5 months.
We can perhaps revert the skips after branching GCC 11 off, but I have
little hope other target maintainers will do what you did, so unsure if it
would help. And the changes need people familiar with each of the backends
to decide what needs to be done and what is doable.
Jakub
next prev parent reply other threads:[~2021-03-31 7:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 10:43 Jakub Jelinek
2021-03-30 11:28 ` Richard Biener
2021-03-30 11:55 ` Jakub Jelinek
2021-03-30 12:33 ` Richard Biener
2021-03-30 15:00 ` [PATCH] testsuite, v2: Disable zero-scratch-regs-{8,9,10,11}.c on all but ... [PR97680] Jakub Jelinek
2021-03-31 6:51 ` [PATCH] testsuite, v2: Disable zero-scratch-regs-{8, 9, 10, 11}.c " Richard Biener
2021-03-31 6:01 ` [PATCH] testsuite: Disable zero-scratch-regs-{8, 9, 10, 11}.c on s390* [PR97680] Eric Botcazou
2021-03-31 7:02 ` Jakub Jelinek [this message]
2021-03-31 7:14 ` Eric Botcazou
2021-03-31 16:59 ` Qing Zhao
2021-04-06 12:55 ` Richard Sandiford
2021-03-30 13:07 ` [PATCH] testsuite: Disable zero-scratch-regs-{8,9,10,11}.c " Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331070236.GO1179226@tucnak \
--to=jakub@redhat.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).