From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id DC1E23858012 for ; Wed, 31 Mar 2021 07:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC1E23858012 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-178-L7eqC_H9OZKTryn7wEKa2A-1; Wed, 31 Mar 2021 03:02:41 -0400 X-MC-Unique: L7eqC_H9OZKTryn7wEKa2A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6F52107ACCD; Wed, 31 Mar 2021 07:02:40 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-95.ams2.redhat.com [10.36.112.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73844A843C; Wed, 31 Mar 2021 07:02:40 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 12V72cMR2871637 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 31 Mar 2021 09:02:38 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 12V72aeB2871636; Wed, 31 Mar 2021 09:02:36 +0200 Date: Wed, 31 Mar 2021 09:02:36 +0200 From: Jakub Jelinek To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Richard Biener Subject: Re: [PATCH] testsuite: Disable zero-scratch-regs-{8,9,10,11}.c on s390* [PR97680] Message-ID: <20210331070236.GO1179226@tucnak> Reply-To: Jakub Jelinek References: <20210330104358.GH1179226@tucnak> <20210330115553.GJ1179226@tucnak> <5697441.lOV4Wx5bFT@fomalhaut> MIME-Version: 1.0 In-Reply-To: <5697441.lOV4Wx5bFT@fomalhaut> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2021 07:02:45 -0000 On Wed, Mar 31, 2021 at 08:01:29AM +0200, Eric Botcazou wrote: > > It looks like the latter - I've seen no attempt by the original authors to > > make the feature work on more targets than they cared for. > > On the other hand, if you hide the failures, there is essentially zero chance > that architecture maintainers pick up the pieces (I personally implemented the > SPARC support only because I had ran into the failures in the testsuite). So > doing the inverse filtering sounds quite counterproductive to me and IMO it's > up to the architecture maintainers to decide on a case-by-case basis. That is true, but nothing really happened during the 5 months that the tests have been failing on many other architectures (except that powerpc and arm had skipped those tests). There has been a PR open for all those 5 months. We can perhaps revert the skips after branching GCC 11 off, but I have little hope other target maintainers will do what you did, so unsure if it would help. And the changes need people familiar with each of the backends to decide what needs to be done and what is doable. Jakub