From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 823D63857831 for ; Thu, 1 Apr 2021 14:00:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 823D63857831 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-pKshpU72PpWOy2QnwcLw3Q-1; Thu, 01 Apr 2021 10:00:34 -0400 X-MC-Unique: pKshpU72PpWOy2QnwcLw3Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46A0318C89E8; Thu, 1 Apr 2021 14:00:30 +0000 (UTC) Received: from localhost (unknown [10.33.36.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE33717B2C; Thu, 1 Apr 2021 14:00:07 +0000 (UTC) Date: Thu, 1 Apr 2021 15:00:06 +0100 From: Jonathan Wakely To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 1/3] libstdc++: Fix elements_view::operator* and operator[] [LWG 3502] Message-ID: <20210401140006.GQ3008@redhat.com> References: <20210329184915.3921422-1-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210329184915.3921422-1-ppalka@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 14:00:43 -0000 On 29/03/21 14:49 -0400, Patrick Palka via Libstdc++ wrote: >While we're modifying elements_view, this also implements the one-line >resolution of LWG 3492. > >libstdc++-v3/ChangeLog: > > * include/std/ranges (__detail::__returnable_element): New > concept. > (elements_view): Use this concept in its constraints. Add > missing private access specifier. > (elements_view::_S_get_element): Define as per LWG 3502. > (elements_view::operator*, elements_view::operator[]): Use > _S_get_element. > (elements_view::operator++): Remove unnecessary constraint > as per LWG 3492. > * testsuite/std/ranges/adaptors/elements.cc (test05): New test. OK, thanks.