public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [committed] ada: Avoid invalid "up" link in manual
@ 2021-04-11 10:16 Gerald Pfeifer
  2021-04-11 10:58 ` Arnaud Charlet
  0 siblings, 1 reply; 4+ messages in thread
From: Gerald Pfeifer @ 2021-04-11 10:16 UTC (permalink / raw)
  To: gcc-patches; +Cc: Sandra Loosemore

This is something I have been noticing for a while, and a hint by 
Sandra in a somewhat similar context taught me how to avoid it.

With this patch the bottom navigation of the page at
  https://gcc.gnu.org/onlinedocs/gnat_ugn/index.html
changes from
  Next: About This Guide, Up: (dir)   [Contents][Index]
to 
  Next: About This Guide   [Contents][Index]
and the invalid "(dir)" link that pointed to
  http://gcc.gnu.org/onlinedocs/dir/index.html
which does not exist is gone.

Pushed.


Gerald (who too late realized that in the Git world he should 
       have added this explanation to the actual commit message)


commit c660464a9ef07726a5d5217b4b39def189ec21e6
Author: Gerald Pfeifer <gerald@pfeifer.com>
Date:   Sun Apr 11 11:23:41 2021 +0200

    ada: Avoid invalid "up" link in manual
    
    gcc/ada/
            * gnat_ugn.texi (Top): Avoid invalid "up" link.

diff --git a/gcc/ada/gnat_ugn.texi b/gcc/ada/gnat_ugn.texi
index 360177b042b..ae8f7580355 100644
--- a/gcc/ada/gnat_ugn.texi
+++ b/gcc/ada/gnat_ugn.texi
@@ -41,7 +41,7 @@ Copyright @copyright{} 2008-2021, Free Software Foundation
 @c %** end of user preamble
 
 @ifnottex
-@node Top
+@node Top, About This Guide
 @top GNAT User's Guide for Native Platforms
 @insertcopying
 @end ifnottex

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [committed] ada: Avoid invalid "up" link in manual
  2021-04-11 10:16 [committed] ada: Avoid invalid "up" link in manual Gerald Pfeifer
@ 2021-04-11 10:58 ` Arnaud Charlet
  2021-04-11 14:57   ` Gerald Pfeifer
  0 siblings, 1 reply; 4+ messages in thread
From: Arnaud Charlet @ 2021-04-11 10:58 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches, Sandra Loosemore


> This is something I have been noticing for a while, and a hint by 
> Sandra in a somewhat similar context taught me how to avoid it.
> 
> With this patch the bottom navigation of the page at
>  https://gcc.gnu.org/onlinedocs/gnat_ugn/index.html
> changes from
>  Next: About This Guide, Up: (dir)   [Contents][Index]
> to 
>  Next: About This Guide   [Contents][Index]
> and the invalid "(dir)" link that pointed to
>  http://gcc.gnu.org/onlinedocs/dir/index.html
> which does not exist is gone.
> 
> Pushed.

Well the master is the rest/sphinx files in doc, the texi file is auto generated, so your change will dispapear at the next generation.

Arno


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [committed] ada: Avoid invalid "up" link in manual
  2021-04-11 10:58 ` Arnaud Charlet
@ 2021-04-11 14:57   ` Gerald Pfeifer
  2021-04-11 15:58     ` Arnaud Charlet
  0 siblings, 1 reply; 4+ messages in thread
From: Gerald Pfeifer @ 2021-04-11 14:57 UTC (permalink / raw)
  To: Arnaud Charlet; +Cc: gcc-patches, Sandra Loosemore

On Sun, 11 Apr 2021, Arnaud Charlet wrote:
>> With this patch the bottom navigation of the page at
>>  https://gcc.gnu.org/onlinedocs/gnat_ugn/index.html
>> changes from
>>   Next: About This Guide, Up: (dir)   [Contents][Index]
>> to 
>>  Next: About This Guide   [Contents][Index]
>> and the invalid "(dir)" link that pointed to
>>  http://gcc.gnu.org/onlinedocs/dir/index.html
>> which does not exist is gone.
> Well the master is the rest/sphinx files in doc, the texi file is auto 
> generated, so your change will dispapear at the next generation.

You're right, good catch, Arnaud!

How can we fix this at the root, then? I'm not sufficiently familiar
with Sphinx and did not find where we might change that.

Is there a newer version of Sphinx available to avoid this?

Gerald

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [committed] ada: Avoid invalid "up" link in manual
  2021-04-11 14:57   ` Gerald Pfeifer
@ 2021-04-11 15:58     ` Arnaud Charlet
  0 siblings, 0 replies; 4+ messages in thread
From: Arnaud Charlet @ 2021-04-11 15:58 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches, Sandra Loosemore, Arnaud Charlet

> >> With this patch the bottom navigation of the page at
> >>  https://gcc.gnu.org/onlinedocs/gnat_ugn/index.html
> >> changes from
> >>   Next: About This Guide, Up: (dir)   [Contents][Index]
> >> to 
> >>  Next: About This Guide   [Contents][Index]
> >> and the invalid "(dir)" link that pointed to
> >>  http://gcc.gnu.org/onlinedocs/dir/index.html
> >> which does not exist is gone.
> > Well the master is the rest/sphinx files in doc, the texi file is auto 
> > generated, so your change will dispapear at the next generation.
> 
> You're right, good catch, Arnaud!
> 
> How can we fix this at the root, then? I'm not sufficiently familiar
> with Sphinx and did not find where we might change that.

You can always do some postprocessing, see gcc/ada/doc/Makefile line 66 for
an existing kludge^Wpostprocessing.

Arno

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-11 15:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-11 10:16 [committed] ada: Avoid invalid "up" link in manual Gerald Pfeifer
2021-04-11 10:58 ` Arnaud Charlet
2021-04-11 14:57   ` Gerald Pfeifer
2021-04-11 15:58     ` Arnaud Charlet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).