From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC
Date: Wed, 14 Apr 2021 14:15:47 -0500 [thread overview]
Message-ID: <20210414191547.GD26583@gate.crashing.org> (raw)
In-Reply-To: <20210414190913.GA1088@ibm-toto.the-meissners.org>
On Wed, Apr 14, 2021 at 03:09:13PM -0400, Michael Meissner wrote:
> On Tue, Apr 13, 2021 at 05:19:12PM -0500, Segher Boessenkool wrote:
> > > * config/rs6000/rs60000.h (FLOAT128_MIN_MAX_FPMASK_P): New macro.
> >
> > As said in the other mail, don't do the macro; just write its expansion
> > in the single place it is used.
>
> Note, in the first patch it is only used 1 time, but in the second patch it is
> used 5 times (4 times in mode iterators in rs6000.md, 1 other use in rs6000.c).
> But I will eliminate it, and replicate it in each of the 6 places it is used.
The alternative is to come up with a much better name :-/
Segher
next prev parent reply other threads:[~2021-04-14 19:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 14:38 [PATCH 0/2] " Michael Meissner
2021-04-09 14:42 ` [PATCH 1/2] " Michael Meissner
2021-04-09 16:54 ` will schmidt
2021-04-13 17:57 ` Segher Boessenkool
2021-04-13 22:19 ` Segher Boessenkool
2021-04-14 19:09 ` Michael Meissner
2021-04-14 19:15 ` Segher Boessenkool [this message]
2021-04-14 20:51 ` Michael Meissner
2021-04-09 14:43 ` [PATCH 2/2] " Michael Meissner
2021-04-09 16:54 ` will schmidt
2021-04-09 19:20 ` Bernhard Reutner-Fischer
2021-04-14 19:01 ` Segher Boessenkool
2021-04-14 20:19 ` Bernhard Reutner-Fischer
2021-04-14 19:38 ` Segher Boessenkool
2021-04-14 20:48 ` Michael Meissner
2021-04-15 15:57 [PATCH 0/2] Add IEEE 128-bit min/max/conditional move Michael Meissner
2021-04-15 16:00 ` [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC Michael Meissner
2021-05-18 20:22 [PATCH 0/2] Add power10 IEEE 128-bit min/max/conditional move support Michael Meissner
2021-05-18 20:26 ` [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC Michael Meissner
2021-05-20 19:25 ` will schmidt
2021-05-21 1:38 ` Michael Meissner
2021-06-07 20:08 ` Segher Boessenkool
2021-06-07 20:25 ` Segher Boessenkool
2021-06-08 23:52 ` Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414191547.GD26583@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).