From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 78365394DAD7 for ; Thu, 15 Apr 2021 16:43:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 78365394DAD7 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-573-sRHZ3qakNsW9nBIbg1F4jg-1; Thu, 15 Apr 2021 12:43:38 -0400 X-MC-Unique: sRHZ3qakNsW9nBIbg1F4jg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 715EA1854E2D; Thu, 15 Apr 2021 16:43:37 +0000 (UTC) Received: from localhost (unknown [10.33.36.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0299B5D9C0; Thu, 15 Apr 2021 16:43:36 +0000 (UTC) Date: Thu, 15 Apr 2021 17:43:36 +0100 From: Jonathan Wakely To: Eric Botcazou Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Add -latomic to test flags for 32-bit sparc-linux Message-ID: <20210415164336.GQ3008@redhat.com> References: <4101124.ejJDZkT8p0@fomalhaut> MIME-Version: 1.0 In-Reply-To: <4101124.ejJDZkT8p0@fomalhaut> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 16:43:42 -0000 On 15/04/21 18:23 +0200, Eric Botcazou wrote: >> Without this I see a number of tests failing when -m32 is used. >> >> libstdc++-v3/ChangeLog: >> >> * testsuite/lib/dg-options.exp (add_options_for_libatomic): Also >> add libatomic options for 32-bit sparc*-*-linux-gnu. >> >> Eric, are you OK with this? It adds -latomic and the appropriate -L >> options to tests that use { dg-add-options libatomic }, because >> sparcv8 needs libatomic for some std::atomic ops. > >Sure, thanks. Thanks, pushed to trunk.