From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0314A3857C7E for ; Fri, 16 Apr 2021 10:13:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0314A3857C7E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-4xlO6Ww2N0WDxutnuDBrlA-1; Fri, 16 Apr 2021 06:13:40 -0400 X-MC-Unique: 4xlO6Ww2N0WDxutnuDBrlA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B7966D4E6; Fri, 16 Apr 2021 10:13:39 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-115-183.ams2.redhat.com [10.36.115.183]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F053E69321; Fri, 16 Apr 2021 10:13:38 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 13GADYMP853056 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 12:13:35 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 13GADXI6853055; Fri, 16 Apr 2021 12:13:33 +0200 Date: Fri, 16 Apr 2021 12:13:33 +0200 From: Jakub Jelinek To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: Re: [PATCH] rtlanal: Don't assume that calls write to a global SP [PR99596] Message-ID: <20210416101333.GM1179226@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2021 10:13:44 -0000 On Fri, Apr 16, 2021 at 10:17:10AM +0100, Richard Sandiford via Gcc-patches wrote: > gcc/ > PR rtl-optimization/99596 > * rtlanal.c (rtx_properties::try_to_add_insn): Don't add global > register accesses for const calls. Assume that pure functions > can only read from global registers. Ignore cases in which > the stack pointer has been marked global. > > gcc/testsuite/ > PR rtl-optimization/99596 > * gcc.target/arm/pr99596.c: New test. LGTM, thanks. Jakub