From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, nathan@acm.org
Subject: Re: [PATCH] preprocessor/100142 - revert unwanted change in last commit
Date: Mon, 19 Apr 2021 12:06:34 +0200 [thread overview]
Message-ID: <20210419100634.GE1179226@tucnak> (raw)
In-Reply-To: <nycvar.YFH.7.76.2104191125020.3760@elmra.sevgm.obk>
On Mon, Apr 19, 2021 at 11:26:04AM +0200, Richard Biener wrote:
> This reverts a s/column_offset/column/ change in the fix for PR99446.
>
> This time with testcase included in the patch and the necessary reversion
> of the testsuite change of the offending rev.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, OK?
>
> Thanks,
> Richard.
>
> 2021-04-19 Richard Biener <rguenther@suse.de>
>
> PR preprocessor/100142
> libcpp/
> * line-map.c (linemap_position_for_loc_and_offset): Revert
> unintended s/column_offset/column/ change.
>
> * gcc.dg/pr100142.c: New testcase.
> * g++.dg/diagnostic/pr72803.C: Revert last change.
LGTM, but please give Nathan 2-3 hours to chime in if the change was
intentional.
Jakub
next prev parent reply other threads:[~2021-04-19 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 9:26 Richard Biener
2021-04-19 10:06 ` Jakub Jelinek [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-19 8:10 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419100634.GE1179226@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).