public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
	Richard Earnshaw <richard.earnshaw@arm.com>,
	Marcus Shawcroft <marcus.shawcroft@arm.com>,
	Kyrylo Tkachov <kyrylo.tkachov@arm.com>,
	gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] aarch64, v2: Fix up 2 other combine opt regressions vs. GCC8 [PR100075]
Date: Mon, 19 Apr 2021 13:44:42 +0200	[thread overview]
Message-ID: <20210419114442.GF1179226@tucnak> (raw)
In-Reply-To: <CAKdteOau4vHcCGZW2y-4c-0T=u-h1Cd2Nu=VV60h68HsMWnDMg@mail.gmail.com>

On Mon, Apr 19, 2021 at 01:16:13PM +0200, Christophe Lyon via Gcc-patches wrote:
> > > Here is an updated patch that I've also successfully bootstrapped/regtested
> > > on aarch64-linux.
> > >
> > > 2021-04-16  Jakub Jelinek  <jakub@redhat.com>
> > >
> > >       PR target/100075
> > >       * config/aarch64/aarch64.md (*neg_asr_si2_extr, *extrsi5_insn_di): New
> > >       define_insn patterns.
> > >
> > >       * gcc.target/aarch64/pr100075.c: New test.
> >
> > OK, thanks.
> >
> 
> Hi,
> 
> The new test fails on aarch64_be, OK to add:
> +/* { dg-require-effective-target aarch64_little_endian } */
> ?
> The testcase looks really endianness dependent.

LGTM, thanks.

	Jakub


      reply	other threads:[~2021-04-19 11:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 15:43 [PATCH] aarch64: " Jakub Jelinek
2021-04-15 18:11 ` Richard Sandiford
2021-04-15 18:51   ` Jakub Jelinek
2021-04-16  7:38     ` [PATCH] aarch64, v2: " Jakub Jelinek
2021-04-16 11:29       ` Richard Sandiford
2021-04-19 11:16         ` Christophe Lyon
2021-04-19 11:44           ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210419114442.GF1179226@tucnak \
    --to=jakub@redhat.com \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@arm.com \
    --cc=marcus.shawcroft@arm.com \
    --cc=richard.earnshaw@arm.com \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).