public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] wwwdocs: Do not rewrite the page titles
@ 2021-04-18 22:45 Jonathan Wakely
  2021-04-19 16:33 ` Richard Kenner
  2021-06-03 15:50 ` Jonathan Wakely
  0 siblings, 2 replies; 8+ messages in thread
From: Jonathan Wakely @ 2021-04-18 22:45 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Remove GNU and FSF attribution from HTML page titles.


I don't see why we should have to "comply with the GNU style" if we're
truly an independent project run by the GCC developers and aided by
the steering committee.

OK for wwwdocs?



[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 746 bytes --]

commit d157082f49725510560cb83f2f1c045e2968ad3b
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Sun Apr 18 23:42:26 2021 +0100

    Do not rewrite the page titles
    
    Remove GNU and FSF attribution from HTML page titles.

diff --git a/htdocs/style.mhtml b/htdocs/style.mhtml
index 677fd05a..eb7c353d 100644
--- a/htdocs/style.mhtml
+++ b/htdocs/style.mhtml
@@ -32,14 +32,6 @@
  </verbatim>
 </define-container>
 
-;;; Redefine the <title> tag to comply with the GNU style.
-
-<define-container title>
-<verbatim><title></verbatim>
-%body
-<verbatim>- GNU Project - Free Software Foundation (FSF)</title></verbatim>
-</define-container>
-
 ;;; Redefine the <body> tag, adding navigation and a standard footer.
 
 <define-container body>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] wwwdocs: Do not rewrite the page titles
  2021-04-18 22:45 [PATCH] wwwdocs: Do not rewrite the page titles Jonathan Wakely
@ 2021-04-19 16:33 ` Richard Kenner
  2021-04-19 19:55   ` Jonathan Wakely
  2021-06-03 15:50 ` Jonathan Wakely
  1 sibling, 1 reply; 8+ messages in thread
From: Richard Kenner @ 2021-04-19 16:33 UTC (permalink / raw)
  To: jwakely; +Cc: gcc-patches

> I don't see why we should have to "comply with the GNU style" if we're
> truly an independent project run by the GCC developers and aided by
> the steering committee.

I think it critical than any code have *some* style guidelines.  If you
don't like the GNU coding convention, which do you propose instead and
how do you propose to convert the existing code to that style?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] wwwdocs: Do not rewrite the page titles
  2021-04-19 16:33 ` Richard Kenner
@ 2021-04-19 19:55   ` Jonathan Wakely
  2021-04-19 20:14     ` Jonathan Wakely
  0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Wakely @ 2021-04-19 19:55 UTC (permalink / raw)
  To: Richard Kenner; +Cc: gcc-patches

On 19/04/21 12:33 -0400, Richard Kenner wrote:
>> I don't see why we should have to "comply with the GNU style" if we're
>> truly an independent project run by the GCC developers and aided by
>> the steering committee.
>
>I think it critical than any code have *some* style guidelines.  If you
>don't like the GNU coding convention, which do you propose instead and
>how do you propose to convert the existing code to that style?

I'm not suggesting any changes to coding conventions. As you say, some
style is needed, and the current one is fine and it would be pointless
churn to change it.

The patch is for the website stylesheet, and simply removes the rule
that rewrites the HTML <title> element to "comply with the GNU style".
If that rule is removed then the page titles will be simply the
original content of the <title> element as it appears in the HTML
source, without rewriting e.g.
https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=blob;f=htdocs/index.html;h=5598df7851048f510b4a70744a1d4c9861157c19;hb=HEAD#l7




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] wwwdocs: Do not rewrite the page titles
  2021-04-19 19:55   ` Jonathan Wakely
@ 2021-04-19 20:14     ` Jonathan Wakely
  0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Wakely @ 2021-04-19 20:14 UTC (permalink / raw)
  To: Richard Kenner; +Cc: gcc-patches

On 19/04/21 20:55 +0100, Jonathan Wakely wrote:
>On 19/04/21 12:33 -0400, Richard Kenner wrote:
>>>I don't see why we should have to "comply with the GNU style" if we're
>>>truly an independent project run by the GCC developers and aided by
>>>the steering committee.
>>
>>I think it critical than any code have *some* style guidelines.  If you
>>don't like the GNU coding convention, which do you propose instead and
>>how do you propose to convert the existing code to that style?
>
>I'm not suggesting any changes to coding conventions. As you say, some
>style is needed, and the current one is fine and it would be pointless
>churn to change it.
>
>The patch is for the website stylesheet, and simply removes the rule
>that rewrites the HTML <title> element to "comply with the GNU style".
>If that rule is removed then the page titles will be simply the
>original content of the <title> element as it appears in the HTML
>source, without rewriting e.g.
>https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=blob;f=htdocs/index.html;h=5598df7851048f510b4a70744a1d4c9861157c19;hb=HEAD#l7

The relevant style guideline is the last bullet at:
https://www.gnu.org/server/standards/gnu-website-guidelines.en.html#html-required

But it's only a "should", and I note that these other GNU projects do
not do it:

https://www.gnu.org/software/gdb/
https://www.gnu.org/software/libc/
https://www.gnu.org/software/guile/
https://www.gnu.org/software/emacs/
https://www.gnu.org/software/guix/

Of the ones I checked, only GCC and Binutils do it.

Since GCC isn't on GNU or FSF hardware and isn't supported financially
by the FSF, and operates independently since the EGCS merger, I don't
see why GCC needs to rewrite the page titles.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] wwwdocs: Do not rewrite the page titles
  2021-04-18 22:45 [PATCH] wwwdocs: Do not rewrite the page titles Jonathan Wakely
  2021-04-19 16:33 ` Richard Kenner
@ 2021-06-03 15:50 ` Jonathan Wakely
  2021-06-03 16:04   ` Jonathan Wakely
  1 sibling, 1 reply; 8+ messages in thread
From: Jonathan Wakely @ 2021-06-03 15:50 UTC (permalink / raw)
  To: gcc-patches

Ping.

Is this OK now?


On 18/04/21 23:45 +0100, Jonathan Wakely wrote:
>Remove GNU and FSF attribution from HTML page titles.
>
>
>I don't see why we should have to "comply with the GNU style" if we're
>truly an independent project run by the GCC developers and aided by
>the steering committee.
>
>OK for wwwdocs?
>
>

>commit d157082f49725510560cb83f2f1c045e2968ad3b
>Author: Jonathan Wakely <jwakely@redhat.com>
>Date:   Sun Apr 18 23:42:26 2021 +0100
>
>    Do not rewrite the page titles
>
>    Remove GNU and FSF attribution from HTML page titles.
>
>diff --git a/htdocs/style.mhtml b/htdocs/style.mhtml
>index 677fd05a..eb7c353d 100644
>--- a/htdocs/style.mhtml
>+++ b/htdocs/style.mhtml
>@@ -32,14 +32,6 @@
>  </verbatim>
> </define-container>
>
>-;;; Redefine the <title> tag to comply with the GNU style.
>-
>-<define-container title>
>-<verbatim><title></verbatim>
>-%body
>-<verbatim>- GNU Project - Free Software Foundation (FSF)</title></verbatim>
>-</define-container>
>-
> ;;; Redefine the <body> tag, adding navigation and a standard footer.
>
> <define-container body>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] wwwdocs: Do not rewrite the page titles
  2021-06-03 15:50 ` Jonathan Wakely
@ 2021-06-03 16:04   ` Jonathan Wakely
  2021-06-15 12:19     ` Gerald Pfeifer
  0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Wakely @ 2021-06-03 16:04 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On 03/06/21 16:50 +0100, Jonathan Wakely wrote:
>Ping.
>
>Is this OK now?
>
>
>On 18/04/21 23:45 +0100, Jonathan Wakely wrote:
>>Remove GNU and FSF attribution from HTML page titles.
>>
>>
>>I don't see why we should have to "comply with the GNU style" if we're
>>truly an independent project run by the GCC developers and aided by
>>the steering committee.
>>
>>OK for wwwdocs?

An alternative change would be to just drop the mention of the FSF,
since they don't fund GCC or provide hosting etc., as in the attached
patch.

And as I pointed out previously, none of these sites refer to the FSF
in their page <title>s:

https://www.gnu.org/software/gdb/
https://www.gnu.org/software/libc/
https://www.gnu.org/software/guile/
https://www.gnu.org/software/emacs/
https://guix.gnu.org/

(Some don't refer to the GNU project either.)



[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 590 bytes --]

diff --git a/htdocs/style.mhtml b/htdocs/style.mhtml
index 677fd05a..1f7139eb 100644
--- a/htdocs/style.mhtml
+++ b/htdocs/style.mhtml
@@ -32,12 +32,12 @@
  </verbatim>
 </define-container>
 
-;;; Redefine the <title> tag to comply with the GNU style.
+;;; Redefine the <title> tag to mention the GNU project.
 
 <define-container title>
 <verbatim><title></verbatim>
 %body
-<verbatim>- GNU Project - Free Software Foundation (FSF)</title></verbatim>
+<verbatim>- GNU Project</title></verbatim>
 </define-container>
 
 ;;; Redefine the <body> tag, adding navigation and a standard footer.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] wwwdocs: Do not rewrite the page titles
  2021-06-03 16:04   ` Jonathan Wakely
@ 2021-06-15 12:19     ` Gerald Pfeifer
  2021-07-27 15:07       ` Jonathan Wakely
  0 siblings, 1 reply; 8+ messages in thread
From: Gerald Pfeifer @ 2021-06-15 12:19 UTC (permalink / raw)
  To: Jonathan Wakely; +Cc: gcc-patches

On Thu, 3 Jun 2021, Jonathan Wakely wrote:
> An alternative change would be to just drop the mention of the FSF
:
> And as I pointed out previously, none of these sites refer to the FSF
> in their page <title>s:
> 
> https://www.gnu.org/software/gdb/
> https://www.gnu.org/software/libc/
> https://www.gnu.org/software/guile/
> https://www.gnu.org/software/emacs/
> https://guix.gnu.org/

Yeah, this makes a lot of sense - having such that ultra long page 
titles really isn't helping anyone and the shorter version even is 
more aligned with those other projects.

Okay.

Gerald

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] wwwdocs: Do not rewrite the page titles
  2021-06-15 12:19     ` Gerald Pfeifer
@ 2021-07-27 15:07       ` Jonathan Wakely
  0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Wakely @ 2021-07-27 15:07 UTC (permalink / raw)
  To: gerald; +Cc: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 127 bytes --]

I've now pushed this wwwdocs patch, which Gerald approved at
https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572796.html



[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 773 bytes --]

commit 0e4db42cddd88d2cc6780da884021284a10b9a4b
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jul 27 16:04:42 2021 +0100

    Remove FSF attribution from HTML page titles

diff --git a/htdocs/style.mhtml b/htdocs/style.mhtml
index 677fd05a..1f7139eb 100644
--- a/htdocs/style.mhtml
+++ b/htdocs/style.mhtml
@@ -32,12 +32,12 @@
  </verbatim>
 </define-container>
 
-;;; Redefine the <title> tag to comply with the GNU style.
+;;; Redefine the <title> tag to mention the GNU project.
 
 <define-container title>
 <verbatim><title></verbatim>
 %body
-<verbatim>- GNU Project - Free Software Foundation (FSF)</title></verbatim>
+<verbatim>- GNU Project</title></verbatim>
 </define-container>
 
 ;;; Redefine the <body> tag, adding navigation and a standard footer.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-27 15:07 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-18 22:45 [PATCH] wwwdocs: Do not rewrite the page titles Jonathan Wakely
2021-04-19 16:33 ` Richard Kenner
2021-04-19 19:55   ` Jonathan Wakely
2021-04-19 20:14     ` Jonathan Wakely
2021-06-03 15:50 ` Jonathan Wakely
2021-06-03 16:04   ` Jonathan Wakely
2021-06-15 12:19     ` Gerald Pfeifer
2021-07-27 15:07       ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).