From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id DEA983894438 for ; Tue, 27 Apr 2021 16:47:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DEA983894438 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-CqC93ta6OjaZN6EfiN4x_A-1; Tue, 27 Apr 2021 12:47:57 -0400 X-MC-Unique: CqC93ta6OjaZN6EfiN4x_A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDFA3107ACF2; Tue, 27 Apr 2021 16:47:55 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-114-59.ams2.redhat.com [10.36.114.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 841545D9C0; Tue, 27 Apr 2021 16:47:55 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 13RGlqCG1554680 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 18:47:52 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 13RGloT01554679; Tue, 27 Apr 2021 18:47:50 +0200 Date: Tue, 27 Apr 2021 18:47:49 +0200 From: Jakub Jelinek To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org, segher@kernel.crashing.org, dje.gcc@gmail.com, jlaw@tachyum.com Subject: Re: [PATCH 01/57] Allow targets to specify build dependencies for out_object_file Message-ID: <20210427164749.GE1179226@tucnak> Reply-To: Jakub Jelinek References: <20210427155719.GC1179226@tucnak> <087ddbc3-94dc-97d9-c8ce-a26186a9290c@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <087ddbc3-94dc-97d9-c8ce-a26186a9290c@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 16:48:01 -0000 On Tue, Apr 27, 2021 at 11:14:00AM -0500, Bill Schmidt wrote: > On 4/27/21 10:57 AM, Jakub Jelinek wrote: > > On Tue, Apr 27, 2021 at 10:32:36AM -0500, Bill Schmidt wrote: > > > 2021-03-03 Bill Schmidt > > > > > > gcc/ > > > * Makefile.in (OUT_FILE_DEPS): New variable. > > > (out_object_file): Depend on OUT_FILE_DEPS. > > Why? > > > > E.g. gcc/config/i386/t-i386 contains: > > i386.o: i386-builtin-types.inc > > Similarly gcc/config/{arm/t-arm,ia64/t-ia64} > > Interesting!  Thanks.  This was probably an excess of caution on my part.  > When I specify something like this, I get a warning message that I am > overriding an automatically generated dependency.  If it's okay for me to > ignore that warning, then I can withdraw this patch and simply specify the > dependency directly.  Sorry, I should have specified the reason for this in > the patch note. Can you state what exact warning is it and perhaps can you try to reproduce that warning with a minimal Makefile example? I don't remember seeing any such warning on i386 or arm. Whether the dependency is specified on the goal with the commands to build it or separately shouldn't really matter. Jakub