From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 375B83A78016 for ; Wed, 28 Apr 2021 17:02:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 375B83A78016 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-4w0zOaSYMsyeNXy1f0G7wA-1; Wed, 28 Apr 2021 13:02:48 -0400 X-MC-Unique: 4w0zOaSYMsyeNXy1f0G7wA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0CD45801B15; Wed, 28 Apr 2021 17:02:47 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-114-59.ams2.redhat.com [10.36.114.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B5FB177F8; Wed, 28 Apr 2021 17:02:45 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 13SH2bcV1805196 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 28 Apr 2021 19:02:37 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 13SH2aBL1805195; Wed, 28 Apr 2021 19:02:36 +0200 Date: Wed, 28 Apr 2021 19:02:36 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: Matthias Klose , gcc-patches , Richard Biener Subject: Re: [Patch] offload-defaulted: Config option to silently ignore uninstalled offload compilers Message-ID: <20210428170236.GV1179226@tucnak> Reply-To: Jakub Jelinek References: <15f34348-0053-2f31-0603-fd0eefa33897@codesourcery.com> <251870a9-85e8-b69b-2f94-841f7548c3ba@ubuntu.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 17:02:52 -0000 On Wed, Apr 28, 2021 at 06:56:37PM +0200, Tobias Burnus wrote: > On 28.04.21 16:13, Matthias Klose wrote: > > > On 4/27/21 12:22 PM, Tobias Burnus wrote: > > > Hence, the distro behaviour is only active when configured with > > > --enable-offload-defaulted. > > please document that option in gcc/doc/install.texi. > > Like attached? Or do you have some other wording suggestions? > > Tobias > > ----------------- > Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf > doc/install.texi: Document --enable-offload-defaulted config option > > Document configure --enable-offload-defaulted option added in > commit r12-218-gfe5bfa6704179f8db7d1ae0b485439e9896df8eb > > gcc/ChangeLog: > > * doc/install.texi (--enable-offload-defaulted): Document. > > diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi > index 4c38244ae58..e5e26571eb1 100644 > --- a/gcc/doc/install.texi > +++ b/gcc/doc/install.texi > @@ -2239,6 +2239,12 @@ specifying paths @var{path1}, @dots{}, @var{pathN}. > --enable-offload-targets=x86_64-intelmicemul-linux-gnu=/path/to/x86_64/compiler,nvptx-none > @end smallexample > > +@item --enable-offload-defaulted > + > +Tell GCC that configured but not installed offload compilers and libgomp > +plugins are silently ignored. Useful for distribution compilers where > +those are in separate optional packages. I'd add at the end "and where the presence or absence of those optional packages should determine the actual supported offloading target set rather than the GCC configure time selection". LGTM otherwise. Jakub