From: Michael Meissner <meissner@linux.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org,
Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] Fix PR bootstrap/100327 (_divkf3.c) on PowerPC
Date: Thu, 29 Apr 2021 12:37:53 -0400 [thread overview]
Message-ID: <20210429163753.GA11318@ibm-toto.the-meissners.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104291630170.178668@digraph.polyomino.org.uk>
On Thu, Apr 29, 2021 at 04:31:50PM +0000, Joseph Myers wrote:
> On Thu, 29 Apr 2021, Michael Meissner via Gcc-patches wrote:
>
> > Fix PR bootstrap/100327 (_divkf3.c) on PowerPC.
> >
> > This patch fixes the PowerPC _divkf3.c module to use the appropriate
> > FLT128 constants if long double is not IEEE 128-bit.
> >
> > I have tested this patch by doing a bootstrap on a little endian power9
> > system running Linux. Can I check this into the trunk?
>
> Why aren't the __LIBGCC_KF_* macros defined? If there's a bug in the
> logic to define macros for all floating-point modes supported by libgcc,
> it should be fixed there. If there's some reason that can't work, the
> commit message needs to explain in more detail.
As Richard points out, the default libgcc_floating_mode_supported_p returns
false for these types. If you add a target hook to return true for these
types, the c-cppbuiltin.c then aborts because there is no suffix for these
types. There is no target hook to define strings to add new suffixes (or
prefixes).
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.ibm.com, phone: +1 (978) 899-4797
next prev parent reply other threads:[~2021-04-29 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 16:13 Michael Meissner
2021-04-29 16:31 ` Joseph Myers
2021-04-29 16:37 ` Michael Meissner [this message]
2021-04-29 16:48 ` Joseph Myers
2021-04-29 21:42 ` Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429163753.GA11318@ibm-toto.the-meissners.org \
--to=meissner@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).