From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Nathan Sidwell <nathan@acm.org>
Subject: [committed] testsuite: Adjust expected error in a testcase [PR98358]
Date: Fri, 30 Apr 2021 15:20:43 +0200 [thread overview]
Message-ID: <20210430132043.GP1179226@tucnak> (raw)
In-Reply-To: <CADzB+2n0yxbAQW==BmKmPMBhHGriup=sBSt=ZeCSWXCNkCSp1Q@mail.gmail.com>
On Fri, Apr 23, 2021 at 05:24:00PM -0400, Jason Merrill via Gcc wrote:
> On Fri, Apr 23, 2021 at 7:55 AM Jakub Jelinek <jakub@redhat.com> wrote:
> >
> > Status
> > ======
> >
> > GCC 8.5 release and closing of the 8 branch is several months overdue,
> > we don't have enough time to maintain trunk and 4 supported release branches.
> > Therefore, I'd like to do 8.5-rc1 on 7th of May and release 8.5 and close
> > the branch a week after that.
> > We have one P1 bug though - P98358 - it is unclear if just changing the
> > testcase is all that is needed or if some C++ FE changes are needed.
>
> The error message quoted in the PR looks correct, so I think changing
> the testcase is sufficient.
Ok, thanks, I've committed the following patch to 8.5 after testing it on
x86_64-linux:
2021-04-30 Jakub Jelinek <jakub@redhat.com>
PR c++/98358
* g++.dg/template/pr98297.C: Expect error about shadowing template template
parameter rather than does not declare anything error.
--- gcc/testsuite/g++.dg/template/pr98297.C.jj 2021-04-22 15:48:48.099179790 +0200
+++ gcc/testsuite/g++.dg/template/pr98297.C 2021-04-30 15:13:57.037421448 +0200
@@ -2,5 +2,5 @@
// { dg-do compile { target c++11 } }
template <template <class> class a>
struct [[b]]
-a <int>; // { dg-error "does not declare anything" }
+a <int>; // { dg-error "name of class shadows template template parameter" }
// { dg-warning "ignored" "" { target *-*-* } .-1 }
Jakub
parent reply other threads:[~2021-04-30 13:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CADzB+2n0yxbAQW==BmKmPMBhHGriup=sBSt=ZeCSWXCNkCSp1Q@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430132043.GP1179226@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).