From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id BBDDC39484A7 for ; Mon, 3 May 2021 06:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BBDDC39484A7 Received: by mail-pj1-x1032.google.com with SMTP id gc22-20020a17090b3116b02901558435aec1so2726543pjb.4 for ; Sun, 02 May 2021 23:28:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nJ+sbLkfCtxu9ApRaC22wjt2rqJ4zaV1Ugrmm1+EQjY=; b=QQzCSdunClZKmwDbp6c8JoyN77WPWMtO8z/VV50ocoaKchH/xJaGKW0wjdSDBjgG5Y WZuP3W10Psu2G6r9cPnz4Fzu4Ym4b6q9MoHVL31hBd3JdIERkchLsp3VMrX8L8bFK1k4 XnjM9QPnKPvrhXBmfMEe8M3TS0ovcYZwuGewx1F8lwNhBnWZsyuRmCXKP8JXVLwnGo8k cIDa4PRTjs8vwUSiNHG7L1tZHrYgLAroQr6AYhl72tFQu4BRmzlrMxzF+5+T82h/gd6T KZWeS+UAgWMnISEDSwrWCQb14ciApDvI2928GfjczL1rsN+kjuNrgpwmC9eHQvcGnRMy 117Q== X-Gm-Message-State: AOAM532/oEhMsswEY9/O7rQWufxWXQXHib7Ws1EFNlDPDtXE9JI8/8/F RlX3lGNR30yEQRyNu1IR/76bdbcSa2B2Ig== X-Google-Smtp-Source: ABdhPJybv3Gf/cRhaeFhJWVTf5sVFvSHWhizgobk1UfoFvIof2fGlYurLoGByYjypm8fSPJ7uDET/A== X-Received: by 2002:a17:90a:f314:: with SMTP id ca20mr19252001pjb.164.1620023310447; Sun, 02 May 2021 23:28:30 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id f3sm18847943pjo.3.2021.05.02.23.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 23:28:29 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 2114741BAA; Mon, 3 May 2021 15:58:26 +0930 (ACST) Date: Mon, 3 May 2021 15:58:26 +0930 From: Alan Modra To: Jeff Law Cc: Simon Marchi , Nick Clifton , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, Binutils Subject: Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure Message-ID: <20210503062825.GG22624@bubble.grove.modra.org> References: <8c1b0ed9-e6f3-9c22-45c5-c2680a2a4830@polymtl.ca> <15701c5f-5653-f0e4-990a-43094d18a702@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15701c5f-5653-f0e4-990a-43094d18a702@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3040.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2021 06:28:34 -0000 On Fri, Apr 30, 2021 at 03:48:00PM -0600, Jeff Law via Gcc-patches wrote: > > On 4/30/2021 12:36 PM, Simon Marchi via Gcc-patches wrote: > > On 2021-04-26 7:32 a.m., Nick Clifton via Gdb-patches wrote:> Hi Guys, > > > Given that gcc, gdb and now binutils are all now requiring C99 as a > > > minimum version of C, are there any objections to updating > > > configure.ac to reflect this ? > > > > > > Cheers > > > Nick > > > > > > diff --git a/configure.ac b/configure.ac > > > index a721316d07b..59b4194fb24 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -1278,7 +1278,7 @@ else > > > WINDMC_FOR_BUILD="\$(WINDMC)" > > > fi > > > > > > -AC_PROG_CC > > > +AC_PROG_CC_C99 > > > AC_PROG_CXX > > > > > > # We must set the default linker to the linker used by gcc for the correct > > Hi Nick, > > > > I think this fix is obvious enough, I encourage you to push it, that > > will fix the build failure many people get in opcodes/ppc-dis.c. We'll > > just remove the line later when we upgrade to Autoconf 2.71, as simple > > as that. For now we use 2.69. If that matters, you have my OK for the > > GDB side of things. > > That works for me.  I'd just sent Alan the trivial patch to make ppc-dis.c > compile again with C89, but if we're going to update configure.ac > appropriately, then it wouldn't be needed. Yes, I prefer the configure fix too. If we state we require C99 in binutils then we ought to be able to use C99.. Nick, does the configure.ac change also need to go in all subdirs, to support people running make in say ld/ rather than running make in the top build dir? -- Alan Modra Australia Development Lab, IBM